[GitHub] [superset] michael-s-molina commented on pull request #18926: fix(explore comma): make that the comma can be added by removing it from token separators…

[GitBox <gi...@apache.org>]

michael-s-molina commented on pull request #18926:
URL: https://github.com/apache/superset/pull/18926#issuecomment-1058078239


   I think a more clean solution is to expose the `tokenSeparators` property that already exists in Ant Design instead of creating a new one.
   
   ```
   type PickedSelectProps = Pick<
     AntdSelectAllProps,
     | 'allowClear'
     | 'autoFocus'
     | 'disabled'
     | 'filterOption'
     | 'labelInValue'
     | 'loading'
     | 'notFoundContent'
     | 'onChange'
     | 'onClear'
     | 'onFocus'
     | 'placeholder'
     | 'showSearch'
     | 'tokenSeparators' <-- include this
     | 'value'
   >;
   
   ...
   
   <StyledSelect
      ...
      tokenSeparators={tokenSeparators || TOKEN_SEPARATORS}
      ...
   >
   ```
   
   All default separators are valid for this control with the exception of the comma. 
   
   ```
   const y_axis_format: SharedControlConfig<'SelectControl'> = {
      ...
      tokenSeparators: ['\n', '\t', ';']
   }
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org