You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "changliiu (via GitHub)" <gi...@apache.org> on 2025/06/30 06:30:29 UTC
[PR] run bomupgrader.py to update Google Cloud-related dependency [beam]
changliiu opened a new pull request, #35480:
URL: https://github.com/apache/beam/pull/35480
**Please** add a meaningful description for your change here
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] run bomupgrader.py to update Google Cloud-related dependency [beam]
Posted by "changliiu (via GitHub)" <gi...@apache.org>.
changliiu commented on PR #35480:
URL: https://github.com/apache/beam/pull/35480#issuecomment-3020796268
> > Done. PTAL thanks!
>
> Sorry if it wasn't clear. It is
>
> ```
> Matchers.equalTo(com.google.errorprone.annotations.CheckReturnValue.class),
> ```
>
> not `classesInPackage` matchers. The latter was for packages. And the test will pass (checked locally)
>
> checked com.google.api.grpc:proto-google-cloud-spanner-v1 resolved to 6.95.1
Done. Thanks so much for the instructions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] run bomupgrader.py to update Google Cloud-related dependency [beam]
Posted by "changliiu (via GitHub)" <gi...@apache.org>.
changliiu commented on PR #35480:
URL: https://github.com/apache/beam/pull/35480#issuecomment-3020305615
> please check the failed test
>
> ```
> testGcpApiSurface (org.apache.beam.sdk.io.gcp.GcpApiSurfaceTest) failed
>
> but: The following disallowed classes appeared on the API surface:
> interface com.google.errorprone.annotations.CheckReturnValue exposed via:
> interface com.google.errorprone.annotations.CheckReturnValue
> ```
>
> to fix, add "com.google.errorprone.annotations.CheckReturnValue" to
>
> https://github.com/apache/beam/blob/510d842170e23cea902e3a21571799f5afd0e727/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/GcpApiSurfaceTest.java#L63
Done. PTAL thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] run bomupgrader.py to update Google Cloud-related dependency [beam]
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn merged PR #35480:
URL: https://github.com/apache/beam/pull/35480
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] run bomupgrader.py to update Google Cloud-related dependency [beam]
Posted by "changliiu (via GitHub)" <gi...@apache.org>.
changliiu commented on PR #35480:
URL: https://github.com/apache/beam/pull/35480#issuecomment-3019819668
assign set of reviewers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] run bomupgrader.py to update Google Cloud-related dependency [beam]
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #35480:
URL: https://github.com/apache/beam/pull/35480#issuecomment-3329131729
It got reverted by the tool due to GCP-BOM version was older. For GCP-BOM managed dependencies we generally avoid pin its versions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] run bomupgrader.py to update Google Cloud-related dependency [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35480:
URL: https://github.com/apache/beam/pull/35480#issuecomment-3019823115
Assigning reviewers:
R: @Abacn for label java.
R: @Abacn for label build.
Note: If you would like to opt out of this review, comment `assign to next reviewer`.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] run bomupgrader.py to update Google Cloud-related dependency [beam]
Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on PR #35480:
URL: https://github.com/apache/beam/pull/35480#issuecomment-3329005472
Was the downgrade of netty required here? We would like to be at least on the version 118 final as it was before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] run bomupgrader.py to update Google Cloud-related dependency [beam]
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #35480:
URL: https://github.com/apache/beam/pull/35480#issuecomment-3020271615
please check the failed test
```
testGcpApiSurface (org.apache.beam.sdk.io.gcp.GcpApiSurfaceTest) failed
but: The following disallowed classes appeared on the API surface:
interface com.google.errorprone.annotations.CheckReturnValue exposed via:
interface com.google.errorprone.annotations.CheckReturnValue
```
to fix, add "com.google.errorprone.annotations.CheckReturnValue" to https://github.com/apache/beam/blob/510d842170e23cea902e3a21571799f5afd0e727/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/GcpApiSurfaceTest.java#L63
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] run bomupgrader.py to update Google Cloud-related dependency [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35480:
URL: https://github.com/apache/beam/pull/35480#issuecomment-3018301148
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment `assign set of reviewers`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] run bomupgrader.py to update Google Cloud-related dependency [beam]
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #35480:
URL: https://github.com/apache/beam/pull/35480#issuecomment-3020781101
> Done. PTAL thanks!
Sorry if it wasn't clear. It is
```
Matchers.equalTo(com.google.errorprone.annotations.CheckReturnValue.class),
```
not `classesInPackage` matchers. The latter was for packages. And the test will pass (checked locally)
checked com.google.api.grpc:proto-google-cloud-spanner-v1 resolved to 6.95.1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org