[GitHub] [incubator-brpc] cdjingit commented on a change in pull request #592: lb configurable && consistency hash lb refactor

[GitBox <gi...@apache.org>]

cdjingit commented on a change in pull request #592: lb configurable && consistency hash lb refactor
URL: https://github.com/apache/incubator-brpc/pull/592#discussion_r272430577
 
 

 ##########
 File path: src/brpc/load_balancer.h
 ##########
 @@ -102,8 +104,21 @@ class LoadBalancer : public NonConstDescribable, public Destroyable {
     // Caller is responsible for Destroy() the instance after usage.
     virtual LoadBalancer* New() const = 0;
 
+    // Config user passed parameters to lb after constrction which 
+    // make lb function more flexible.
+    virtual bool SetParameters(const butil::StringPiece& params) { return true; }
 
 Review comment:
   参数解析是在每个类自己决定的，所以直接传了字符串

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org