You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by jkff <gi...@git.apache.org> on 2017/08/04 23:51:11 UTC

[GitHub] beam pull request #3693: [BEAM-2734] Unbreaks some Dataflow ValidatesRunner ...

GitHub user jkff opened a pull request:

    https://github.com/apache/beam/pull/3693

    [BEAM-2734] Unbreaks some Dataflow ValidatesRunner tests

    This is a partial revert of https://github.com/apache/beam/pull/3649, changing UnboundedReadFromBoundedSource to be identical to the version before that PR.
    
    The Source is serialized in the pipeline and deserialized on the worker using the worker's different (fixed per-worker) version of runners-core-construction so the serialVersionUID has to match.
    
    This Source does not declare a serialVersionUID, so one is computed by the JVM automatically, and in practice that means the class needs to be completely identical.
    
    The current PR is a quick emergency fix. The right solution is I suppose to declare a serialVersionUID for everything serializable in runners-core-construction, or to make the worker not contain a fixed version of runners-core-construction (not sure if it's feasible) - but it's outside the scope of this PR.
    
    R: @tgroh 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jkff/incubator-beam unbreak-serialization

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/3693.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3693
    
----
commit fc0c3c00613ab6524d621353ea44b5fb0646bcfa
Author: Eugene Kirpichov <ki...@google.com>
Date:   2017-08-04T23:46:42Z

    [BEAM-2734] Unbreaks some Dataflow ValidatesRunner tests

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] beam pull request #3693: [BEAM-2734] Unbreaks some Dataflow ValidatesRunner ...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/beam/pull/3693


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---