[GitHub] [incubator-pinot] xiangfu0 commented on pull request #6872: Make zookeeper, kafka, controller, broker use random port for integration tests

[GitBox <gi...@apache.org>]

xiangfu0 commented on pull request #6872:
URL: https://github.com/apache/incubator-pinot/pull/6872#issuecomment-830686408


   > This seems to require an implicit sequencing of `findRandomOpenPort()` and creating the listening sockets from within the services during startup. Otherwise, there's a chance of a conflict. (which doesn't actually happen bc the [port isn't random](https://docs.oracle.com/javase/7/docs/api/java/net/ServerSocket.html#getLocalPort())) :P)
   
   Agreed. I will change the method name to `findOpenPort()` since it's not random


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org