You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Andrey Zagrebin (Jira)" <ji...@apache.org> on 2020/02/21 11:16:00 UTC
[jira] [Comment Edited] (FLINK-15621) State TTL: Remove deprecated
option and method to disable TTL compaction filter
[ https://issues.apache.org/jira/browse/FLINK-15621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17040999#comment-17040999 ]
Andrey Zagrebin edited comment on FLINK-15621 at 2/21/20 11:15 AM:
-------------------------------------------------------------------
[~jamesbondu]
Indeed, they weirdly fail in my IDE. Maybe, [~zhongwei] could help with it. Could you create an issue for that?
Usually you can just run locally tests which are relevant to your change, e.g. in IDE. Then you push your dev branch to your github fork. This should trigger a CI build if you have set it up for your github account. At the moment, we use Travis and Azure Pipelines. Travis is about to be removed so I would recommend Azure Pipelines. You can setup both CIs for your github repo and check test runs there. This is what will eventually matter to merge the PR.
was (Author: azagrebin):
**[~jamesbondu]
Indeed, they weirdly fail in my IDE. Maybe, [~zhongwei] could help with it. Could you create an issue for that?
Usually you can just run locally tests which are relevant to your change, e.g. in IDE. Then you push your dev branch to your github fork. This should trigger a CI build if you have set it up for your github account. At the moment, we use Travis and Azure Pipelines. Travis is about to be removed so I would recommend Azure Pipelines. You can setup both CIs for your github repo and check test runs there. This is what will eventually matter to merge the PR.
> State TTL: Remove deprecated option and method to disable TTL compaction filter
> -------------------------------------------------------------------------------
>
> Key: FLINK-15621
> URL: https://issues.apache.org/jira/browse/FLINK-15621
> Project: Flink
> Issue Type: Task
> Components: Runtime / State Backends
> Reporter: Andrey Zagrebin
> Assignee: Arujit Pradhan
> Priority: Blocker
> Fix For: 1.11.0
>
>
> Follow-up for FLINK-15506.
> * Remove RocksDBOptions#TTL_COMPACT_FILTER_ENABLED
> * Remove RocksDBStateBackend#enableTtlCompactionFilter/isTtlCompactionFilterEnabled/disableTtlCompactionFilter, also in python API
> * Cleanup code from this flag and tests, also in python API
> * Check any related code in [frocksdb|https://github.com/dataArtisans/frocksdb] if any
--
This message was sent by Atlassian Jira
(v8.3.4#803005)