You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Diana Arroyo <da...@us.ibm.com> on 2016/01/13 14:45:46 UTC

Review Request 42250: CMake: Add sasl and dl link flags, add curl link library and add protobuf library directory.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42250/
-----------------------------------------------------------

Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Joseph Wu.


Bugs: MESOS-3843
    https://issues.apache.org/jira/browse/MESOS-3843


Repository: mesos


Description
-------

CMake: Add sasl and dl link flags, add curl link library and add protobuf library directory.


Diffs
-----

  src/slave/cmake/FindCurl.cmake PRE-CREATION 
  src/slave/cmake/SlaveConfigure.cmake fbdfdaa27fbd8c7429861eea5baf401a221f748b 

Diff: https://reviews.apache.org/r/42250/diff/


Testing
-------

originally https://reviews.apache.org/r/41108/.  When attempting to address final review this review was created instead of modifiying original.  See https://reviews.apache.org/r/41108/ for testing comments.


Thanks,

Diana Arroyo


Re: Review Request 42250: CMake: Add sasl and dl link flags, add curl link library and add protobuf library directory.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42250/#review114224
-----------------------------------------------------------


Bad patch!

Reviews applied: [42250]

Failed command: ./support/apply-review.sh -n -r 42250

Error:
 2016-01-13 17:01:38 URL:https://reviews.apache.org/r/42250/diff/raw/ [5875/5875] -> "42250.patch" [1]
error: src/slave/cmake/FindCurl.cmake: already exists in index

- Mesos ReviewBot


On Jan. 13, 2016, 1:45 p.m., Diana Arroyo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42250/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2016, 1:45 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Joseph Wu.
> 
> 
> Bugs: MESOS-3843
>     https://issues.apache.org/jira/browse/MESOS-3843
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> CMake: Add sasl and dl link flags, add curl link library and add protobuf library directory.
> 
> 
> Diffs
> -----
> 
>   src/slave/cmake/FindCurl.cmake PRE-CREATION 
>   src/slave/cmake/SlaveConfigure.cmake fbdfdaa27fbd8c7429861eea5baf401a221f748b 
> 
> Diff: https://reviews.apache.org/r/42250/diff/
> 
> 
> Testing
> -------
> 
> originally https://reviews.apache.org/r/41108/.  When attempting to address final review this review was created instead of modifiying original.  See https://reviews.apache.org/r/41108/ for testing comments.
> 
> 
> Thanks,
> 
> Diana Arroyo
> 
>