[GitHub] mgaido91 commented on a change in pull request #22957: [SPARK-25951][SQL] Ignore aliases for distributions and orderings

[GitBox <gi...@apache.org>]

mgaido91 commented on a change in pull request #22957: [SPARK-25951][SQL] Ignore aliases for distributions and orderings
URL: https://github.com/apache/spark/pull/22957#discussion_r242083672
 
 

 ##########
 File path: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala
 ##########
 @@ -1549,6 +1551,38 @@ class DatasetSuite extends QueryTest with SharedSQLContext {
       Seq(Row("Amsterdam")))
   }
 
+  test("SPARK-25951: avoid redundant shuffle on rename") {
 
 Review comment:
   > Looking at this test case, it seems updating the outputPartitioning according to the project list is good enough?
   
   Basically, that is what is done. The diff is quite big, that's true, but mostly are tests. Is there something specific you are worried about?
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org