[jira] [Commented] (YARN-9124) Resolve contradiction in ResourceUtils: addMandatoryResources / checkMandatoryResources work differently

["Adam Antal (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-9124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16802839#comment-16802839 ] 

Adam Antal commented on YARN-9124:
----------------------------------

Hi [~snemeth],

Are you no longer working on this? May I assign this to myself?

> Resolve contradiction in ResourceUtils: addMandatoryResources / checkMandatoryResources work differently
> --------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-9124
>                 URL: https://issues.apache.org/jira/browse/YARN-9124
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Szilard Nemeth
>            Priority: Minor
>
> {{ResourceUtils#addMandatoryResources}}: Adds only memory and vcores as mandatory resources.
> {{ResourceUtils#checkMandatoryResources}}: YARN-6620 added some code to this. This method not only checks memory and vcores, but all the resources referred in ResourceInformation#MANDATORY_RESOURCES.
> I think it would be good to call {{MANDATORY_RESOURCES}} as {{PREDEFINED_RESOURCES}} or something like that and use a similar name for {{checkMandatoryResources}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org