You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "lixiaojiee (GitHub)" <gi...@apache.org> on 2018/11/21 09:27:18 UTC
[GitHub] [incubator-dubbo-website] lixiaojiee opened pull request
#185: #184:fix a wrong word
## What is the purpose of the change
the page "文档-框架设计" has a wrong word,the word "Dubbo" is spelled as "D ubbo"，as shown the picture below:
## Brief changelog
correct it as "Dubbo",as shown the picture below:
Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-dubbo-website/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [ ] Format the pull request title like `Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Test your code locally by running `docsite start`, and make sure it works as expected.
- [ ] Make sure no files under build directory is added.
- [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide).
[ Full content available at: https://github.com/apache/incubator-dubbo-website/pull/185 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo-website] lovepoem commented on issue #185:
#184:fix a wrong word
Posted by "lovepoem (GitHub)" <gi...@apache.org>.
The markdown file needs to be converted to HTML to see the effect on the web page. I will merge the markdown file at first.
[ Full content available at: https://github.com/apache/incubator-dubbo-website/pull/185 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo-website] lovepoem closed pull request #185:
#184:fix a wrong word
Posted by "lovepoem (GitHub)" <gi...@apache.org>.
[ pull request closed by lovepoem ]
[ Full content available at: https://github.com/apache/incubator-dubbo-website/pull/185 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo-website] lixiaojiee commented on issue
#185: #184:fix a wrong word
Posted by "lixiaojiee (GitHub)" <gi...@apache.org>.
您好，我在提交的时候在checklist里面附上了转换成网页的效果图，并标注了修改点，因为是第一次尝试提交，可能有的地方不太规范，如有不足，还烦请指正，非常感谢。
下图是我刚才重新截取的图片，请查看。[cid:d55d3dba-7471-498d-bf30-a2b24349dc42]
________________________________
发件人: Xin Wang <no...@github.com>
发送时间: 2018年11月21日 20:24
收件人: apache/incubator-dubbo-website
抄送: ateacer; Author
主题: Re: [apache/incubator-dubbo-website] #184:fix a wrong word (#185)
Merged #185<https://github.com/apache/incubator-dubbo-website/pull/185> into asf-site.
―
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<https://github.com/apache/incubator-dubbo-website/pull/185#event-1979910819>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AhOUGBcNt3GL0r2s0l-QS_5a45CnBdBXks5uxUYKgaJpZM4Yst6z>.
[ Full content available at: https://github.com/apache/incubator-dubbo-website/pull/185 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org