You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/06/14 08:23:54 UTC
[GitHub] [kafka] tkaszuba opened a new pull request, #12293: KAFKA-13963: Clarified java doc for processors api
tkaszuba opened a new pull request, #12293:
URL: https://github.com/apache/kafka/pull/12293
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.*
### Committer Checklist (excluded from commit message)
- [x] Verify design and implementation
- [x] Verify test coverage and CI build status
- [x] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] tkaszuba commented on a diff in pull request #12293: KAFKA-13963: Clarified java doc for processors api
Posted by GitBox <gi...@apache.org>.
tkaszuba commented on code in PR #12293:
URL: https://github.com/apache/kafka/pull/12293#discussion_r897565836
##########
streams/src/main/java/org/apache/kafka/streams/TopologyDescription.java:
##########
@@ -30,6 +30,7 @@
* In contrast, two sub-topologies are not connected but can be linked to each other via topics, i.e., if one
* sub-topology {@link Topology#addSink(String, String, String...) writes} into a topic and another sub-topology
* {@link Topology#addSource(String, String...) reads} from the same topic.
+ * Processors and Transformers created with the Processor API are treated as black boxes and are not represented in the topology graph.
Review Comment:
that is correct, the issue is with context.forward
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mjsax merged pull request #12293: KAFKA-13963: Clarified java doc for processors api
Posted by GitBox <gi...@apache.org>.
mjsax merged PR #12293:
URL: https://github.com/apache/kafka/pull/12293
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mjsax commented on a diff in pull request #12293: KAFKA-13963: Clarified java doc for processors api
Posted by GitBox <gi...@apache.org>.
mjsax commented on code in PR #12293:
URL: https://github.com/apache/kafka/pull/12293#discussion_r897429237
##########
streams/src/main/java/org/apache/kafka/streams/TopologyDescription.java:
##########
@@ -30,6 +30,7 @@
* In contrast, two sub-topologies are not connected but can be linked to each other via topics, i.e., if one
* sub-topology {@link Topology#addSink(String, String, String...) writes} into a topic and another sub-topology
* {@link Topology#addSource(String, String...) reads} from the same topic.
+ * Processors and Transformers created with the Processor API are treated as black boxes and are not represented in the topology graph.
Review Comment:
> are not represented
Sounds a little bit like "missing". Also, using the (plain) Processor API, there are only `Processors` anyway -- `Transformers` are part of the DSL-PAPI-integration.
If you use the Processor API, you would still connect Processors to define your graph (eg, `addProcessor(..., <parentProcessor>)` and those connections are represented in the `TopologyDescription`.
The point from the jira was (if I understood it correctly), that `context.forward()` (which does not define the actually structure of the topology, as it does not connect `Processor` but just uses _existing_ connections) is not part of the `TopologyDescription`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] tkaszuba commented on a diff in pull request #12293: KAFKA-13963: Clarified java doc for processors api
Posted by GitBox <gi...@apache.org>.
tkaszuba commented on code in PR #12293:
URL: https://github.com/apache/kafka/pull/12293#discussion_r901070812
##########
streams/src/main/java/org/apache/kafka/streams/TopologyDescription.java:
##########
@@ -30,6 +30,7 @@
* In contrast, two sub-topologies are not connected but can be linked to each other via topics, i.e., if one
* sub-topology {@link Topology#addSink(String, String, String...) writes} into a topic and another sub-topology
* {@link Topology#addSource(String, String...) reads} from the same topic.
+ * Processors and Transformers created with the Processor API are treated as black boxes and are not represented in the topology graph.
Review Comment:
ok, updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mjsax commented on pull request #12293: KAFKA-13963: Clarified java doc for processors api
Posted by GitBox <gi...@apache.org>.
mjsax commented on PR #12293:
URL: https://github.com/apache/kafka/pull/12293#issuecomment-1168118034
Thanks for the PR! Merged to `trunk`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mjsax commented on a diff in pull request #12293: KAFKA-13963: Clarified java doc for processors api
Posted by GitBox <gi...@apache.org>.
mjsax commented on code in PR #12293:
URL: https://github.com/apache/kafka/pull/12293#discussion_r898266334
##########
streams/src/main/java/org/apache/kafka/streams/TopologyDescription.java:
##########
@@ -30,6 +30,7 @@
* In contrast, two sub-topologies are not connected but can be linked to each other via topics, i.e., if one
* sub-topology {@link Topology#addSink(String, String, String...) writes} into a topic and another sub-topology
* {@link Topology#addSource(String, String...) reads} from the same topic.
+ * Processors and Transformers created with the Processor API are treated as black boxes and are not represented in the topology graph.
Review Comment:
Can you update the PR to re-phrase it so it's easier to understand?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org