You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by d2r <gi...@git.apache.org> on 2018/10/03 21:30:36 UTC

[GitHub] storm pull request #2862: STORM-3238: Reduces scope of wrapper, corrects var...

GitHub user d2r opened a pull request:

    https://github.com/apache/storm/pull/2862

    STORM-3238: Reduces scope of wrapper, corrects variable

    https://www.w3schools.com/js/js_this.asp
    
    > In a function definition, this refers to the "owner" of the function.
    
    When we wrapped this in an anonymous function, the data that `this` pointed to changed. So it is a simple fix to pull the variable from the outer scope.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/d2r/storm storm-3238-fix-log-search-results

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/2862.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2862
    
----
commit ee516cebb6fe2ad516df6444087dc02d44e93c98
Author: Derek Dagit <de...@...>
Date:   2018-10-03T21:28:19Z

    Reduces scope of wrapper, corrects variable

----


---

[GitHub] storm pull request #2862: STORM-3238: Reduces scope of wrapper, corrects var...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/storm/pull/2862


---

[GitHub] storm issue #2862: STORM-3238: Reduces scope of wrapper, corrects variable

Posted by d2r <gi...@git.apache.org>.

Github user d2r commented on the issue:

    https://github.com/apache/storm/pull/2862
  
    Thank you @kishorvpatil for the review. I have merged this to master branch.


---