[GitHub] [pulsar-client-go] wolfstudy commented on a change in pull request #12: package logrus for project

[GitBox <gi...@apache.org>]

wolfstudy commented on a change in pull request #12: package logrus for project
URL: https://github.com/apache/pulsar-client-go/pull/12#discussion_r284958236
 
 

 ##########
 File path: pulsar/internal/lookup_service.go
 ##########
 @@ -81,7 +81,7 @@ func (ls *lookupService) Lookup(topic string) (*LookupResult, error) {
 			return nil, err
 		}
 
-		log.WithField("topic", topic).Debugf("Got topic lookup response: %s", res)
+		log.Debugf("got topic: %s lookup response: %s", topic, res)
 
 Review comment:
   If we really have this kind of scenario requirement, we can repackage the `WithField` method as follows:
   
   ```
   func WithField(key string, value interface{}) *log.Entry {
       return log.WithField(key, value)
   }
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services