You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by ps...@apache.org on 2006/11/25 21:13:46 UTC

svn commit: r479187 - /jakarta/commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/PoolableConnectionFactory.java

Author: psteitz
Date: Sat Nov 25 12:13:45 2006
New Revision: 479187

URL: http://svn.apache.org/viewvc?view=rev&rev=479187
Log:
Eliminated wildcard imports, fixed string equals comparison.

Modified:
    jakarta/commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/PoolableConnectionFactory.java

Modified: jakarta/commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/PoolableConnectionFactory.java
URL: http://svn.apache.org/viewvc/jakarta/commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/PoolableConnectionFactory.java?view=diff&rev=479187&r1=479186&r2=479187
==============================================================================
--- jakarta/commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/PoolableConnectionFactory.java (original)
+++ jakarta/commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/PoolableConnectionFactory.java Sat Nov 25 12:13:45 2006
@@ -21,7 +21,10 @@
 import java.sql.Statement;
 import java.sql.ResultSet;
 import java.sql.SQLException;
-import org.apache.commons.pool.*;
+import org.apache.commons.pool.KeyedObjectPool;
+import org.apache.commons.pool.KeyedObjectPoolFactory;
+import org.apache.commons.pool.PoolableObjectFactory;
+import org.apache.commons.pool.ObjectPool;
 
 /**
  * A {@link PoolableObjectFactory} that creates
@@ -384,7 +387,7 @@
                 conn.setReadOnly(_defaultReadOnly.booleanValue());
             }
             if ((_defaultCatalog != null) &&
-                    (conn.getCatalog() != _defaultCatalog)) {
+                    (!_defaultCatalog.equals(conn.getCatalog()))) {
                 conn.setCatalog(_defaultCatalog);
             }
         }



---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org