You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by Justin Ross <jr...@redhat.com> on 2013/01/07 22:04:56 UTC
Re: 0.20 release update - RC3 is out, C++ and proton problem
Hi, Keith. This one is big enough that I want to double check. Is this
still a good change for 0.20? (For example, have subsequent CI runs on
trunk been clean?) Also, is it a regression?
Thanks,
Justin
On Thu, 27 Dec 2012, Keith W wrote:
> Hi Justin,
>
> Can I request the inclusion of QPID-4503 in 0.20? It is a small
> changs in a narrow area of code to address a race condition in a
> feature to detect producer transaction timeouts.
>
> http://svn.apache.org/viewvc?view=revision&revision=1421884
> http://svn.apache.org/viewvc?view=revision&revision=1424427
>
> Kind regards, Keith.
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
Re: 0.20 release update - RC3 is out, C++ and proton problem
Posted by Keith W <ke...@gmail.com>.
On 8 January 2013 18:19, Justin Ross <jr...@redhat.com> wrote:
> Thanks for helping to settle my qualms. Approved for 0.20.
>>>> http://svn.apache.org/viewvc?**view=revision&revision=1421884
>>>> http://svn.apache.org/viewvc?**view=revision&revision=1424427
Thanks Justin. Those changes are now merged to 0.20 and have already
passed on Jenkins on the relevent job (Qpid-Java-Java-Test-0.20 #101).
Kind regards, Keith.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
Re: 0.20 release update - RC3 is out, C++ and proton problem
Posted by Justin Ross <jr...@redhat.com>.
Thanks for helping to settle my qualms. Approved for 0.20.
Justin
On Tue, 8 Jan 2013, Robbie Gemmell wrote:
> It isn't as big a change as it might appear (some of its size is simply due
> to duplication, which Keith has since separately refactored out on trunk).
>
> The first change amounts to doing a single call to retrieve a time value
> instead of two seperate calls which might span a change in the value. The
> second change is resetting a value so that it is not compared in cases
> where it should not have been (whereby a stale value from an older
> operation was incorrectly being used for a comparison).
>
> The changes are fairly minor, and only really have any effect if the
> associated feature is enabled (which it isnt by default). They have been on
> trunk for a few weeks without issue in CI, and even before then were
> already given to the lucky users who experienced the issues prompting the
> change. They are not a regression from 0.18 however.
>
> Robbie
>
> On 7 January 2013 21:04, Justin Ross <jr...@redhat.com> wrote:
>
>> Hi, Keith. This one is big enough that I want to double check. Is this
>> still a good change for 0.20? (For example, have subsequent CI runs on
>> trunk been clean?) Also, is it a regression?
>>
>> Thanks,
>> Justin
>>
>>
>> On Thu, 27 Dec 2012, Keith W wrote:
>>
>> Hi Justin,
>>>
>>> Can I request the inclusion of QPID-4503 in 0.20? It is a small
>>> changs in a narrow area of code to address a race condition in a
>>> feature to detect producer transaction timeouts.
>>>
>>> http://svn.apache.org/viewvc?**view=revision&revision=1421884<http://svn.apache.org/viewvc?view=revision&revision=1421884>
>>> http://svn.apache.org/viewvc?**view=revision&revision=1424427<http://svn.apache.org/viewvc?view=revision&revision=1424427>
>>>
>>> Kind regards, Keith.
>>>
>>>
>> ------------------------------**------------------------------**---------
>> To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.**org<de...@qpid.apache.org>
>> For additional commands, e-mail: dev-help@qpid.apache.org
>>
>>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
Re: 0.20 release update - RC3 is out, C++ and proton problem
Posted by Robbie Gemmell <ro...@gmail.com>.
It isn't as big a change as it might appear (some of its size is simply due
to duplication, which Keith has since separately refactored out on trunk).
The first change amounts to doing a single call to retrieve a time value
instead of two seperate calls which might span a change in the value. The
second change is resetting a value so that it is not compared in cases
where it should not have been (whereby a stale value from an older
operation was incorrectly being used for a comparison).
The changes are fairly minor, and only really have any effect if the
associated feature is enabled (which it isnt by default). They have been on
trunk for a few weeks without issue in CI, and even before then were
already given to the lucky users who experienced the issues prompting the
change. They are not a regression from 0.18 however.
Robbie
On 7 January 2013 21:04, Justin Ross <jr...@redhat.com> wrote:
> Hi, Keith. This one is big enough that I want to double check. Is this
> still a good change for 0.20? (For example, have subsequent CI runs on
> trunk been clean?) Also, is it a regression?
>
> Thanks,
> Justin
>
>
> On Thu, 27 Dec 2012, Keith W wrote:
>
> Hi Justin,
>>
>> Can I request the inclusion of QPID-4503 in 0.20? It is a small
>> changs in a narrow area of code to address a race condition in a
>> feature to detect producer transaction timeouts.
>>
>> http://svn.apache.org/viewvc?**view=revision&revision=1421884<http://svn.apache.org/viewvc?view=revision&revision=1421884>
>> http://svn.apache.org/viewvc?**view=revision&revision=1424427<http://svn.apache.org/viewvc?view=revision&revision=1424427>
>>
>> Kind regards, Keith.
>>
>>
> ------------------------------**------------------------------**---------
> To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.**org<de...@qpid.apache.org>
> For additional commands, e-mail: dev-help@qpid.apache.org
>
>