You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2020/01/02 14:47:54 UTC

[GitHub] [mynewt-nimble] szymon-czapracki opened a new pull request #715: nimble/btshell: Add support for sync reporting

szymon-czapracki opened a new pull request #715: nimble/btshell: Add support for sync reporting
URL: https://github.com/apache/mynewt-nimble/pull/715
 
 
   Allows to enable periodic advertising sync reporting.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-nimble] andrzej-kaczmarek merged pull request #715: nimble/btshell: Add support for toggling reporting

Posted by GitBox <gi...@apache.org>.
andrzej-kaczmarek merged pull request #715: nimble/btshell: Add support for toggling reporting
URL: https://github.com/apache/mynewt-nimble/pull/715
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-nimble] andrzej-kaczmarek commented on a change in pull request #715: nimble/btshell: Add support for toggling reporting

Posted by GitBox <gi...@apache.org>.
andrzej-kaczmarek commented on a change in pull request #715: nimble/btshell: Add support for toggling reporting
URL: https://github.com/apache/mynewt-nimble/pull/715#discussion_r362550623
 
 

 ##########
 File path: apps/btshell/src/cmd.c
 ##########
 @@ -4550,6 +4595,13 @@ static const struct shell_cmd btshell_commands[] = {
         .sc_cmd_func = cmd_sync_transfer_receive,
 #if MYNEWT_VAL(SHELL_CMD_HELP)
         .help = &sync_transfer_receive_help,
+#endif
+    },
+    {
+       .sc_cmd = "sync_reporting",
 
 Review comment:
   should be `sync-reporting` (same as other sync commands)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-nimble] andrzej-kaczmarek commented on a change in pull request #715: nimble/btshell: Add support for toggling reporting

Posted by GitBox <gi...@apache.org>.
andrzej-kaczmarek commented on a change in pull request #715: nimble/btshell: Add support for toggling reporting
URL: https://github.com/apache/mynewt-nimble/pull/715#discussion_r362551055
 
 

 ##########
 File path: apps/btshell/src/cmd.c
 ##########
 @@ -3861,6 +3894,18 @@ static const struct shell_cmd_help sync_transfer_help = {
     .usage = NULL,
     .params = sync_transfer_params,
 };
+
+static const struct shell_param sync_reporting_params[] = {
+    {"sync_handle", "sync handle, usage: =[UINT16], default: 0"},
+    {"toggle_reporting", "toggle reporting, usage: =[0-1], default: 0"},
 
 Review comment:
   `enabled`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-nimble] andrzej-kaczmarek commented on a change in pull request #715: nimble/btshell: Add support for toggling reporting

Posted by GitBox <gi...@apache.org>.
andrzej-kaczmarek commented on a change in pull request #715: nimble/btshell: Add support for toggling reporting
URL: https://github.com/apache/mynewt-nimble/pull/715#discussion_r362550990
 
 

 ##########
 File path: apps/btshell/src/cmd.c
 ##########
 @@ -3861,6 +3894,18 @@ static const struct shell_cmd_help sync_transfer_help = {
     .usage = NULL,
     .params = sync_transfer_params,
 };
+
+static const struct shell_param sync_reporting_params[] = {
+    {"sync_handle", "sync handle, usage: =[UINT16], default: 0"},
+    {"toggle_reporting", "toggle reporting, usage: =[0-1], default: 0"},
+    {NULL, NULL}
+};
+
+static const struct shell_cmd_help sync_reporting_help = {
+   .summary = "start periodic advertising sync reporting",
 
 Review comment:
   better describe it as "configure" instead of "start"

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-nimble] szymon-czapracki commented on issue #715: nimble/btshell: Add support for sync reporting

Posted by GitBox <gi...@apache.org>.
szymon-czapracki commented on issue #715: nimble/btshell: Add support for sync reporting
URL: https://github.com/apache/mynewt-nimble/pull/715#issuecomment-570229165
 
 
   @sjanc FYI

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services