You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2014/10/25 05:17:17 UTC
Review Request 27188: Use ship-it instead of +/-1.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27188/
-----------------------------------------------------------
Review request for Aurora and Jake Farrell.
Repository: aurora
Description
-------
Use ship-it instead of +/-1.
Diffs
-----
build-support/jenkins/review_feedback.py 9d22358608d0d52019df0c4c5b96b08d0f157c43
Diff: https://reviews.apache.org/r/27188/diff/
Testing
-------
None yet, will do a dry run Monday before committing.
Thanks,
Bill Farner
Re: Review Request 27188: Use ship-it instead of +/-1.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27188/#review58481
-----------------------------------------------------------
+1: Master (3778330) is green with this patch.
./build-support/jenkins/build.sh
- Aurora ReviewBot
On Oct. 25, 2014, 3:17 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27188/
> -----------------------------------------------------------
>
> (Updated Oct. 25, 2014, 3:17 a.m.)
>
>
> Review request for Aurora and Jake Farrell.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Use ship-it instead of +/-1.
>
>
> Diffs
> -----
>
> build-support/jenkins/review_feedback.py 9d22358608d0d52019df0c4c5b96b08d0f157c43
>
> Diff: https://reviews.apache.org/r/27188/diff/
>
>
> Testing
> -------
>
> None yet, will do a dry run Monday before committing.
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 27188: Use ship-it instead of +/-1.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27188/#review58638
-----------------------------------------------------------
Ship it!
Ship It!
- Maxim Khutornenko
On Oct. 27, 2014, 5:55 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27188/
> -----------------------------------------------------------
>
> (Updated Oct. 27, 2014, 5:55 p.m.)
>
>
> Review request for Aurora and Maxim Khutornenko.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Use ship-it instead of +/-1.
>
>
> Diffs
> -----
>
> build-support/jenkins/review_feedback.py 9d22358608d0d52019df0c4c5b96b08d0f157c43
>
> Diff: https://reviews.apache.org/r/27188/diff/
>
>
> Testing
> -------
>
> None yet, will do a dry run Monday before committing.
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 27188: Use ship-it instead of +/-1.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27188/
-----------------------------------------------------------
(Updated Oct. 27, 2014, 5:55 p.m.)
Review request for Aurora and Maxim Khutornenko.
Repository: aurora
Description
-------
Use ship-it instead of +/-1.
Diffs
-----
build-support/jenkins/review_feedback.py 9d22358608d0d52019df0c4c5b96b08d0f157c43
Diff: https://reviews.apache.org/r/27188/diff/
Testing
-------
None yet, will do a dry run Monday before committing.
Thanks,
Bill Farner
Re: Review Request 27188: Use ship-it instead of +/-1.
Posted by Joe Smith <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27188/#review58480
-----------------------------------------------------------
Ship it!
Ship It!
- Joe Smith
On Oct. 24, 2014, 8:17 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27188/
> -----------------------------------------------------------
>
> (Updated Oct. 24, 2014, 8:17 p.m.)
>
>
> Review request for Aurora and Jake Farrell.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Use ship-it instead of +/-1.
>
>
> Diffs
> -----
>
> build-support/jenkins/review_feedback.py 9d22358608d0d52019df0c4c5b96b08d0f157c43
>
> Diff: https://reviews.apache.org/r/27188/diff/
>
>
> Testing
> -------
>
> None yet, will do a dry run Monday before committing.
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 27188: Use ship-it instead of +/-1.
Posted by Joshua Cohen <jc...@twopensource.com>.
> On Oct. 25, 2014, 4:39 a.m., Joshua Cohen wrote:
> > _~
> > _~)_)_~
> > )_))_))_)
> > _!__!__!_
> > ______t/
> > ~~~~~~~~~~~~~
Wow did that ever not format properly!
https://github.com/reviewboard/rb-extension-pack/blob/master/shipit_ascii_art/shipit_ascii_art/asciiart.py#L4
- Joshua
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27188/#review58483
-----------------------------------------------------------
On Oct. 25, 2014, 3:17 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27188/
> -----------------------------------------------------------
>
> (Updated Oct. 25, 2014, 3:17 a.m.)
>
>
> Review request for Aurora and Jake Farrell.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Use ship-it instead of +/-1.
>
>
> Diffs
> -----
>
> build-support/jenkins/review_feedback.py 9d22358608d0d52019df0c4c5b96b08d0f157c43
>
> Diff: https://reviews.apache.org/r/27188/diff/
>
>
> Testing
> -------
>
> None yet, will do a dry run Monday before committing.
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 27188: Use ship-it instead of +/-1.
Posted by Joshua Cohen <jc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27188/#review58483
-----------------------------------------------------------
Ship it!
_~
_~)_)_~
)_))_))_)
_!__!__!_
______t/
~~~~~~~~~~~~~
- Joshua Cohen
On Oct. 25, 2014, 3:17 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27188/
> -----------------------------------------------------------
>
> (Updated Oct. 25, 2014, 3:17 a.m.)
>
>
> Review request for Aurora and Jake Farrell.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Use ship-it instead of +/-1.
>
>
> Diffs
> -----
>
> build-support/jenkins/review_feedback.py 9d22358608d0d52019df0c4c5b96b08d0f157c43
>
> Diff: https://reviews.apache.org/r/27188/diff/
>
>
> Testing
> -------
>
> None yet, will do a dry run Monday before committing.
>
>
> Thanks,
>
> Bill Farner
>
>