You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by tripodsan <gi...@git.apache.org> on 2014/04/21 07:12:57 UTC
[GitHub] cordova-osx pull request: Update OSX Support for CLI
GitHub user tripodsan opened a pull request:
https://github.com/apache/cordova-osx/pull/2
Update OSX Support for CLI
fixes the following issues and allows to successfully clean,build,run osx platform on cli
* CB-2920 Add a ./cordova/clean project-level script for OSX
* CB-2934 Add a ./cordova/build project-level script for OSX
* CB-2946 Add a ./cordova/run project-level script for OSX
* CB-2802 add a ./bin/check_reqs script to OS X
* CB-2803 Add CLI scripts for OS X
* CB-3343 OSX - add version script
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tripodsan/cordova-osx master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-osx/pull/2.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2
----
commit 0717c60ee6c8367ee0136654d279dcef8010d7a1
Author: Tobias Bocanegra <tr...@adobe.com>
Date: 2014-04-17T23:43:07Z
Update to modern layout
commit ceb7039a786fe1bcf79bfe74a7b384baabaabd76
Author: Tobias Bocanegra <tr...@adobe.com>
Date: 2014-04-18T23:53:23Z
Adding better default icons and copy the project icons during build phase
commit 615c59f119017c25f2a63ac04e2d3ad8a5e063bb
Author: Tobias Bocanegra <tr...@adobe.com>
Date: 2014-04-18T23:58:09Z
Removing some unused menu items
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-osx pull request: Update OSX Support for CLI
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:
https://github.com/apache/cordova-osx/pull/2#issuecomment-41100684
Ok, I majorly failed in reviewing this commit (pushed it prematurely).
Issues:
1. No www folder reference when you create a new project
2. Build error "cordova/lib/copy-www-build-step.sh" missing in Run Script Build Phase
3. Runtime exception: "config.xml" does not exist (missing in the app as well)
4. Minimum deployment target should be 10.8, not 10.9 (no biggie though)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-osx pull request: Update OSX Support for CLI
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:
https://github.com/apache/cordova-osx/pull/2#issuecomment-41110134
Great! It builds fine now. Integrated and pushed to apache.
You can close this PR now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-osx pull request: Update OSX Support for CLI
Posted by tripodsan <gi...@git.apache.org>.
Github user tripodsan commented on the pull request:
https://github.com/apache/cordova-osx/pull/2#issuecomment-41102924
I'll look into it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-osx pull request: Update OSX Support for CLI
Posted by tripodsan <gi...@git.apache.org>.
Github user tripodsan commented on the pull request:
https://github.com/apache/cordova-osx/pull/2#issuecomment-41110458
thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-osx pull request: Update OSX Support for CLI
Posted by tripodsan <gi...@git.apache.org>.
Github user tripodsan closed the pull request at:
https://github.com/apache/cordova-osx/pull/2
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-osx pull request: Update OSX Support for CLI
Posted by tripodsan <gi...@git.apache.org>.
Github user tripodsan commented on the pull request:
https://github.com/apache/cordova-osx/pull/2#issuecomment-41104300
when I do:
````
$ mkdir osx-test
$ cordova-osx/bin/create osx-test org.apache.people.tripod.osxtest osxtest
$ cd osx-test/
$ ./cordova/build
$ ./cordova/run
````
it builds and runs perfectly
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-osx pull request: Update OSX Support for CLI
Posted by tripodsan <gi...@git.apache.org>.
Github user tripodsan commented on the pull request:
https://github.com/apache/cordova-osx/pull/2#issuecomment-41109049
the problem was that `.gitignore` contains `build` and `lib` and did hide some of my files.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---