You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/04/13 22:21:09 UTC
[GitHub] [superset] ktmud opened a new pull request, #19703: chore(build): upgrade less-loader
ktmud opened a new pull request, #19703:
URL: https://github.com/apache/superset/pull/19703
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
`npm install` starts to complain about incompatible peerDependencies:
```
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving: less-loader@5.0.0
npm ERR! Found: webpack@5.52.1
npm ERR! node_modules/webpack
npm ERR! dev webpack@"^5.52.1" from the root project
npm ERR! peerOptional webpack@">=4" from @cypress/react@5.10.1
npm ERR! node_modules/@cypress/react
npm ERR! dev @cypress/react@"^5.10.0" from the root project
npm ERR! 33 more (@storybook/addon-essentials, @storybook/addon-docs, ...)
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer webpack@"^2.0.0 || ^3.0.0 || ^4.0.0" from less-loader@5.0.0
npm ERR! node_modules/less-loader
npm ERR! dev less-loader@"^5.0.0" from the root project
npm ERR!
npm ERR! Conflicting peer dependency: webpack@4.46.0
npm ERR! node_modules/webpack
npm ERR! peer webpack@"^2.0.0 || ^3.0.0 || ^4.0.0" from less-loader@5.0.0
npm ERR! node_modules/less-loader
npm ERR! dev less-loader@"^5.0.0" from the root project
npm ERR!
```
Let's upgrade less-loader to fix it.
Also removing engine requirement in the eslint-plugin-theme-colors plugin as it's throwing unnecessary warnings.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #19703: chore(build): upgrade less-loader
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #19703:
URL: https://github.com/apache/superset/pull/19703#issuecomment-1098564569
# [Codecov](https://codecov.io/gh/apache/superset/pull/19703?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19703](https://codecov.io/gh/apache/superset/pull/19703?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3d4abaa) into [master](https://codecov.io/gh/apache/superset/commit/5fc0651aaba9f2d7ed6605bea9cc44254cd6e02f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5fc0651) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #19703 +/- ##
=======================================
Coverage 66.51% 66.51%
=======================================
Files 1684 1684
Lines 64560 64560
Branches 6625 6625
=======================================
Hits 42939 42939
Misses 19926 19926
Partials 1695 1695
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `51.15% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19703?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19703?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [5fc0651...3d4abaa](https://codecov.io/gh/apache/superset/pull/19703?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codemaster08240328 commented on pull request #19703: chore(build): upgrade less-loader
Posted by GitBox <gi...@apache.org>.
codemaster08240328 commented on PR #19703:
URL: https://github.com/apache/superset/pull/19703#issuecomment-1104421579
@ktmud , after this update, I removed all my node modules, installed it again.
Then when I try to run frontend using `npm run dev-server` it throws an error:
```
ERROR in ./src/assets/stylesheets/antd/index.less (./node_modules/css-loader/dist/cjs.js??ruleSet[1].rules[5].use[1]!./node_modules/less-loader/dist/cjs.js??ruleSet[1].rules[5].use[2]!./src/assets/stylesheets/antd/index.less)
Module build failed (from ./node_modules/less-loader/dist/cjs.js):
// @import './variable.less';
@import './@{root-entry-name}.less';
^
Variable @root-entry-name is undefined
Error in /Volumes/Work/assignment/preset/superset/superset-frontend/node_modules/antd/lib/style/themes/index.less (line 7, column 8)
```
Can you please check it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on a diff in pull request #19703: chore(build): upgrade less-loader
Posted by GitBox <gi...@apache.org>.
ktmud commented on code in PR #19703:
URL: https://github.com/apache/superset/pull/19703#discussion_r850566043
##########
superset-frontend/tools/eslint-plugin-theme-colors/package.json:
##########
@@ -9,9 +9,5 @@
"keywords": [],
"license": "Apache-2.0",
"author": "Apache",
- "dependencies": {},
- "engines": {
- "node": "^16.9.1",
- "npm": "^7.5.4"
Review Comment:
Yeah, this package itself is very simple and it's only used internally. I don't think the engine requirement is necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on pull request #19703: chore(build): upgrade less-loader
Posted by GitBox <gi...@apache.org>.
ktmud commented on PR #19703:
URL: https://github.com/apache/superset/pull/19703#issuecomment-1105775776
@codemaster08240328 did you modify `./src/assets/stylesheets/antd/index.less` locally by any chance? I don't think the variable `root-entry-name` is in current Superset codebase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on pull request #19703: chore(build): upgrade less-loader
Posted by GitBox <gi...@apache.org>.
ktmud commented on PR #19703:
URL: https://github.com/apache/superset/pull/19703#issuecomment-1098588515
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on a diff in pull request #19703: chore(build): upgrade less-loader
Posted by GitBox <gi...@apache.org>.
rusackas commented on code in PR #19703:
URL: https://github.com/apache/superset/pull/19703#discussion_r850166330
##########
superset-frontend/tools/eslint-plugin-theme-colors/package.json:
##########
@@ -9,9 +9,5 @@
"keywords": [],
"license": "Apache-2.0",
"author": "Apache",
- "dependencies": {},
- "engines": {
- "node": "^16.9.1",
- "npm": "^7.5.4"
Review Comment:
This was just bumped to support npm 8 in [this](https://github.com/apache/superset/pull/19365) PR. Not sure if it's _necessary_ but thought I should ping @villebro in case it is.
Happy to approve this otherwise, though if this doesn't become an objection. Thanks for tending to this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on a diff in pull request #19703: chore(build): upgrade less-loader
Posted by GitBox <gi...@apache.org>.
rusackas commented on code in PR #19703:
URL: https://github.com/apache/superset/pull/19703#discussion_r850178877
##########
superset-frontend/webpack.config.js:
##########
@@ -383,7 +383,9 @@ const config = {
loader: 'less-loader',
options: {
sourceMap: isDevMode,
Review Comment:
Just opened up [a PR](https://github.com/apache/superset/pull/19710) to take a quick shot at this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #19703: chore(build): upgrade less-loader
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #19703:
URL: https://github.com/apache/superset/pull/19703#issuecomment-1102843208
Ephemeral environment shutdown and build artifacts deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on a diff in pull request #19703: chore(build): upgrade less-loader
Posted by GitBox <gi...@apache.org>.
rusackas commented on code in PR #19703:
URL: https://github.com/apache/superset/pull/19703#discussion_r850167139
##########
superset-frontend/webpack.config.js:
##########
@@ -383,7 +383,9 @@ const config = {
loader: 'less-loader',
options: {
sourceMap: isDevMode,
Review Comment:
Tangential discussion, but it seems like we should just leave sourcemaps on all the time... browsers (at least Chrome) don't download them unless the dev tools are open, so I don't think there' a downside.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #19703: chore(build): upgrade less-loader
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #19703:
URL: https://github.com/apache/superset/pull/19703#issuecomment-1098589313
@ktmud Ephemeral environment spinning up at http://35.89.103.133:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud merged pull request #19703: chore(build): upgrade less-loader
Posted by GitBox <gi...@apache.org>.
ktmud merged PR #19703:
URL: https://github.com/apache/superset/pull/19703
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org