[jira] Commented: (HBASE-2593) Race Between Log Splitting and Log Writing

["Todd Lipcon (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-2593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12870154#action_12870154 ] 

Todd Lipcon commented on HBASE-2593:
------------------------------------

bq. Between the time that the regionserver is marked as dead and fs.append is issued, the regionserver could exit a GC pause and maintain the lease

How can this happen? If it loses its ZK session, then the regionserver will notice this and shut itself down. So we'll only spin in recoverLog if the regionserver is stuck unable to shut down, for some reason.

> Race Between Log Splitting and Log Writing
> ------------------------------------------
>
>                 Key: HBASE-2593
>                 URL: https://issues.apache.org/jira/browse/HBASE-2593
>             Project: Hadoop HBase
>          Issue Type: Bug
>          Components: master, regionserver
>    Affects Versions: 0.21.0
>            Reporter: Nicolas Spiegelberg
>            Assignee: Nicolas Spiegelberg
>            Priority: Critical
>             Fix For: 0.21.0
>
>
> The current method for recovering the lease in HLog.splitLog() is flawed.  Between the time that the regionserver is marked as dead and fs.append is issued, the regionserver could exit a GC pause and maintain the lease.  In this case, fs.append() would continually fail.  The master needs to not only recover the lease in splitLog but also break the lease so regionserver writes will no longer pass.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.