You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jclouds.apache.org by Apache Wiki <wi...@apache.org> on 2014/11/25 16:33:25 UTC

[Jclouds Wiki] Trivial Update of "How to Contribute" by EverettToews

Dear Wiki user,

You have subscribed to a wiki page or wiki category on "Jclouds Wiki" for change notification.

The "How to Contribute" page has been changed by EverettToews:
https://wiki.apache.org/jclouds/How%20to%20Contribute?action=diff&rev1=16&rev2=17

  
  During the review process you may be asked to make some changes to your submission. While working through feedback, it can be beneficial to create new commits so the incremental change is obvious.  This can also lead to a complex set of commits, and having an atomic change per commit is preferred in the end.  Use your best judgement and work with your reviewer as to when you should revise a commit or create a new one.
  
- A pull request is considered ready to be merged once it gets at lease one +1 from a reviewer. Once all the changes have been completed and the pull request is accepted, it '''__must be rebased to the latest upstream version__'''. It is also a good idea to squash all the commits into a single one, since this will allow us to generate a clean patch and merge it properly.
+ A pull request is considered ready to be merged once it gets at lease one +1 from a reviewer. Once all the changes have been completed and the pull request is accepted, it '''__must be rebased to the latest upstream version__'''. It is also a good idea to squash all the commits into a single one, since this will allow us to generate a clean patch and merge it properly.