[I] [C++][CMake] Use arrow/util/config.h.cmake instead of add_definitions() [arrow]

["kou (via GitHub)" <gi...@apache.org>]

kou opened a new issue, #40221:
URL: https://github.com/apache/arrow/issues/40221

   ### Describe the enhancement requested
   
   It's easy to maintain. `add_definitions()` is directory scope. So we have `add_definitions(-DARROW_WITH_ZLIB)` in `cpp/src/arrow/` and `cpp/src/parquet/`
   
   ### Component(s)
   
   C++


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] [C++][CMake] Use arrow/util/config.h.cmake instead of add_definitions() [arrow]

["kou (via GitHub)" <gi...@apache.org>]

kou closed issue #40221: [C++][CMake] Use arrow/util/config.h.cmake instead of add_definitions()
URL: https://github.com/apache/arrow/issues/40221


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] [C++][CMake] Use arrow/util/config.h.cmake instead of add_definitions() [arrow]

["kou (via GitHub)" <gi...@apache.org>]

kou commented on issue #40221:
URL: https://github.com/apache/arrow/issues/40221#issuecomment-1962742742

   Issue resolved by pull request 40222
   https://github.com/apache/arrow/pull/40222


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org