You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/11/15 00:51:04 UTC
[GitHub] [incubator-superset] codecov-io commented on issue #8575:
Math.max(...array) considered harmful
codecov-io commented on issue #8575: Math.max(...array) considered harmful
URL: https://github.com/apache/incubator-superset/pull/8575#issuecomment-554157383
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8575?src=pr&el=h1) Report
> Merging [#8575](https://codecov.io/gh/apache/incubator-superset/pull/8575?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/78f41b38e187758643d32cb9ee4de6b444f1da31?src=pr&el=desc) will **increase** coverage by `5.11%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/8575/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/8575?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #8575 +/- ##
==========================================
+ Coverage 66.5% 71.62% +5.11%
==========================================
Files 450 118 -332
Lines 23117 12587 -10530
Branches 2451 0 -2451
==========================================
- Hits 15375 9016 -6359
+ Misses 7593 3571 -4022
+ Partials 149 0 -149
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8575?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/8575/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `55.55% <0%> (-27.78%)` | :arrow_down: |
| [...sets/src/explore/components/ExploreChartHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8575/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvRXhwbG9yZUNoYXJ0SGVhZGVyLmpzeA==) | | |
| [superset/assets/src/components/Checkbox.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8575/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0NoZWNrYm94LmpzeA==) | | |
| [...perset/assets/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/8575/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvdXRpbC9nZXRFbXB0eUxheW91dC5qcw==) | | |
| [...ts/src/dashboard/util/getComponentWidthFromDrop.js](https://codecov.io/gh/apache/incubator-superset/pull/8575/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvdXRpbC9nZXRDb21wb25lbnRXaWR0aEZyb21Ecm9wLmpz) | | |
| [.../assets/src/dashboard/reducers/dashboardFilters.js](https://codecov.io/gh/apache/incubator-superset/pull/8575/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvcmVkdWNlcnMvZGFzaGJvYXJkRmlsdGVycy5qcw==) | | |
| [...rc/explore/components/controls/AnnotationLayer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8575/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvY29udHJvbHMvQW5ub3RhdGlvbkxheWVyLmpzeA==) | | |
| [superset/assets/src/welcome/DashboardTable.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8575/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy93ZWxjb21lL0Rhc2hib2FyZFRhYmxlLmpzeA==) | | |
| [...erset/assets/src/dashboard/util/injectCustomCss.js](https://codecov.io/gh/apache/incubator-superset/pull/8575/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvdXRpbC9pbmplY3RDdXN0b21Dc3MuanM=) | | |
| [...explore/components/controls/ColorPickerControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8575/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvY29udHJvbHMvQ29sb3JQaWNrZXJDb250cm9sLmpzeA==) | | |
| ... and [322 more](https://codecov.io/gh/apache/incubator-superset/pull/8575/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8575?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8575?src=pr&el=footer). Last update [78f41b3...df02493](https://codecov.io/gh/apache/incubator-superset/pull/8575?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org