You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2020/08/07 15:00:38 UTC
[GitHub] [cordova-plugin-splashscreen] erisu commented on a change in pull request #286: (docs): Add Information about how to use Dark Mode SplashScreens
erisu commented on a change in pull request #286:
URL: https://github.com/apache/cordova-plugin-splashscreen/pull/286#discussion_r467094143
##########
File path: README.md
##########
@@ -177,6 +179,13 @@ If not all DPI images are considered, some devices might not show a SplashScreen
| xxhdpi | 960x1600 | 1600x960 |
| xxxhdpi | 1280x1920 | 1920x1280 |
+#### Dark Mode
+
+You can easily provide an extra SplashScreen Image for NightMode/DarkMode enabled Devices.
+Do this by addign **-night** at the correct Place in the `density`.
Review comment:
```suggestion
To do this, add the keyword `-night` in between the image's **layout** and **size** keywords of the `density` attribute value. E.g.: `land-night-hdpi`
```
##########
File path: README.md
##########
@@ -177,6 +179,13 @@ If not all DPI images are considered, some devices might not show a SplashScreen
| xxhdpi | 960x1600 | 1600x960 |
| xxxhdpi | 1280x1920 | 1920x1280 |
+#### Dark Mode
+
+You can easily provide an extra SplashScreen Image for NightMode/DarkMode enabled Devices.
Review comment:
```suggestion
You can easily provide an extra SplashScreen image for NightMode/DarkMode enabled devices.
```
##########
File path: README.md
##########
@@ -177,6 +179,13 @@ If not all DPI images are considered, some devices might not show a SplashScreen
| xxhdpi | 960x1600 | 1600x960 |
| xxxhdpi | 1280x1920 | 1920x1280 |
+#### Dark Mode
+
+You can easily provide an extra SplashScreen Image for NightMode/DarkMode enabled Devices.
+Do this by addign **-night** at the correct Place in the `density`.
+
+The correct Place is between the Image Layout and the Size. See [the Example Configuration](#example-android-configuration).
Review comment:
```suggestion
For more examples, please see [the Example Configuration](#example-android-configuration) section.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org