You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "Antonio-RiveroMartnez (via GitHub)" <gi...@apache.org> on 2023/04/06 15:01:56 UTC

[GitHub] [superset] Antonio-RiveroMartnez commented on a diff in pull request #23599: feat(presto): `get_catalog_names`

Antonio-RiveroMartnez commented on code in PR #23599:
URL: https://github.com/apache/superset/pull/23599#discussion_r1159926131


##########
superset/db_engine_specs/postgres.py:
##########
@@ -310,7 +310,7 @@ def get_catalog_names(
 SELECT datname FROM pg_database
 WHERE datistemplate = false;
             """
-            ).fetchall()

Review Comment:
   Curious about why this had to change?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org