You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "Joe McDonnell (Jira)" <ji...@apache.org> on 2023/04/20 16:11:00 UTC
[jira] [Commented] (IMPALA-12070) Don't build bison and autotools in the native-toolchain
[ https://issues.apache.org/jira/browse/IMPALA-12070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17714665#comment-17714665 ]
Joe McDonnell commented on IMPALA-12070:
----------------------------------------
Toolchain change: [https://github.com/cloudera/native-toolchain/commit/c3b592c345ba3218e6cc9d9741777771ea2b7cb8]
{noformat}
commit c3b592c345ba3218e6cc9d9741777771ea2b7cb8
Author: Joe McDonnell <jo...@cloudera.com>
Date: Sun Apr 16 16:01:38 2023 -0700
IMPALA-12070: Use autotools/bison from the OS rather than building it
This stops building autoconf, automake, bison, and libtool.
These utilities are already installed in the docker images,
so this removes any code that used the toolchain version
of these. This is useful from a license perspective, because
several of these are GPL licensed. Removing them avoids any
complications due to licensing, and it brings the native-toolchain
code closer to compatibility with Apache Impala.
This also removes unused build code for cyrus-sasl, krb5,
and openssl. This code remains in the history and can be
revived at any time.
Testing:
- Ran a full toolchain build
Change-Id: I2f0603671fa443b26b3a339874f4154e853e2a06
Reviewed-on: http://gerrit.cloudera.org:8080/19756
Reviewed-by: Michael Smith <mi...@cloudera.com>
Reviewed-by: Wenzhe Zhou <wz...@cloudera.com>
Tested-by: Joe McDonnell <jo...@cloudera.com>
{noformat}
> Don't build bison and autotools in the native-toolchain
> -------------------------------------------------------
>
> Key: IMPALA-12070
> URL: https://issues.apache.org/jira/browse/IMPALA-12070
> Project: IMPALA
> Issue Type: Improvement
> Components: Infrastructure
> Affects Versions: Impala 4.3.0
> Reporter: Joe McDonnell
> Assignee: Joe McDonnell
> Priority: Major
>
> The native-toolchain builds autoconf, automake, libtool, and bison. However, these are completely unnecessary. These utilities are installed into the docker images used for the build, and almost all components use the utilities from OS rather than the toolchain.
> The only exceptions to this are pieces of old code that have been sitting around for 5+ years.
> We should stop building these as part of the toolchain. This helps reduce the references to GPL code in the repository.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org