You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/08/11 06:26:50 UTC
[GitHub] [pulsar] tisonkun opened a new pull request, #17062: [build][sql] Make pulsar-trino-disto self-contained
tisonkun opened a new pull request, #17062:
URL: https://github.com/apache/pulsar/pull/17062
- [x] `doc-not-needed`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on a diff in pull request #17062: [build][sql] Make pulsar-trino-disto self-contained
Posted by GitBox <gi...@apache.org>.
tisonkun commented on code in PR #17062:
URL: https://github.com/apache/pulsar/pull/17062#discussion_r959414765
##########
bin/pulsar:
##########
@@ -177,17 +177,23 @@ if [ ! -f "${PY_INSTANCE_FILE}" ]; then
PY_INSTANCE_FILE=${BUILT_PY_INSTANCE_FILE}
fi
-# find pulsar sql presto distribution location
-check_presto_libraries() {
- if [ ! -d "${PRESTO_HOME}" ]; then
-
- BUILT_PRESTO_HOME="${SQL_HOME}/presto-distribution/target/pulsar-presto-distribution"
- if [ ! -d "${BUILT_PRESTO_HOME}" ]; then
- echo "\nCouldn't find presto distribution.";
- echo "Make sure you've run 'mvn package'\n";
- exit 1;
+# find pulsar sql trino distribution location
+check_trino_libraries() {
+ if [ ! -d "${TRINO_HOME}" ]; then
+ # TODO: As PIP-200 accepted, this compatibility is not promised. Refactor when we drop this b/w compatibility.
+ FALLBACK_PRESTO_HOME="${PULSAR_HOME}/lib/presto"
Review Comment:
This should be internal dependency and users should not and cannot manage it.
Pulsar SQL tightly couples with the bundled trino distro.
Will revert the "compatibility" part.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on a diff in pull request #17062: [build][sql] Make pulsar-trino-disto self-contained
Posted by GitBox <gi...@apache.org>.
tisonkun commented on code in PR #17062:
URL: https://github.com/apache/pulsar/pull/17062#discussion_r959393863
##########
bin/pulsar:
##########
@@ -257,8 +257,8 @@ if [ -z "$PULSAR_LOG_CONF" ]; then
PULSAR_LOG_CONF=$DEFAULT_LOG_CONF
fi
-if [ -z "$PULSAR_PRESTO_CONF" ]; then
- PULSAR_PRESTO_CONF=$DEFAULT_PULSAR_PRESTO_CONF
+if [ -z "$PULSAR_TRINO_CONF" ]; then
Review Comment:
Oops. I think I misunderstand your suggestion, followup as 362207d3e54369175bca2553609f10ba0855ca7d.
Then a version upgrade should go well, while a downgrade needs a caveat. And anyway, PIP-200 publicly drop the previous configure so that we can drop it in the following versions. This is for a smoothly deprecating period.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on a diff in pull request #17062: [build][sql] Make pulsar-trino-disto self-contained
Posted by GitBox <gi...@apache.org>.
tisonkun commented on code in PR #17062:
URL: https://github.com/apache/pulsar/pull/17062#discussion_r962102149
##########
.github/workflows/ci-owasp-dep-check.yaml:
##########
@@ -87,7 +87,7 @@ jobs:
docker rmi $(docker images -q) -f
df -h
- # Projects dependent on flume, hdfs, hbase, and presto currently excluded from the scan.
+ # Projects dependent on flume, hdfs, hbase, and trino currently excluded from the scan.
Review Comment:
This patch doesn't actually touch dependencies. OWASP failed due to this comment edition triggering validation. The failures can be resolved in another turn.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nicoloboschi merged pull request #17062: [build][sql] Make pulsar-trino-disto self-contained
Posted by GitBox <gi...@apache.org>.
nicoloboschi merged PR #17062:
URL: https://github.com/apache/pulsar/pull/17062
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #17062: [build][sql] Make pulsar-trino-disto self-contained
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #17062:
URL: https://github.com/apache/pulsar/pull/17062#issuecomment-1239083271
Now broker group 1 tests don't like me :(
Rerun later >_<
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on a diff in pull request #17062: [build][sql] Make pulsar-trino-disto self-contained
Posted by GitBox <gi...@apache.org>.
tisonkun commented on code in PR #17062:
URL: https://github.com/apache/pulsar/pull/17062#discussion_r947677971
##########
distribution/server/src/assemble/bin.xml:
##########
@@ -23,6 +23,7 @@
xsi:schemaLocation="http://maven.apache.org/ASSEMBLY/2.1.0 http://maven.apache.org/xsd/assembly-2.1.0.xsd">
<id>bin</id>
<formats>
+ <format>dir</format>
Review Comment:
Yep. The generated folder takes 421M. I will revert it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #17062: [build][sql] Make pulsar-trino-disto self-contained
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #17062:
URL: https://github.com/apache/pulsar/pull/17062#issuecomment-1237770271
Thanks for your reviews! I think this patch is ready for merge. @eolivelli @codelipenghui @nicoloboschi could you help with performing the merge?
After it's merged I'll update the corresponding docs and then we can close PIP-200 as completed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #17062: [build][sql] Make pulsar-trino-disto self-contained
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #17062:
URL: https://github.com/apache/pulsar/pull/17062#issuecomment-1238829434
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #17062: [build][sql] Make pulsar-trino-disto self-contained
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #17062:
URL: https://github.com/apache/pulsar/pull/17062#issuecomment-1238797126
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nicoloboschi commented on a diff in pull request #17062: [build][sql] Make pulsar-trino-disto self-contained
Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on code in PR #17062:
URL: https://github.com/apache/pulsar/pull/17062#discussion_r957400269
##########
bin/pulsar:
##########
@@ -257,8 +257,8 @@ if [ -z "$PULSAR_LOG_CONF" ]; then
PULSAR_LOG_CONF=$DEFAULT_LOG_CONF
fi
-if [ -z "$PULSAR_PRESTO_CONF" ]; then
- PULSAR_PRESTO_CONF=$DEFAULT_PULSAR_PRESTO_CONF
+if [ -z "$PULSAR_TRINO_CONF" ]; then
Review Comment:
for better handling retrocompatibility we could still check PULSAR_PRESTO_CONF as fallback. something like this:
```
if [ -z "$PULSAR_TRINO_CONF" ]; then
if [ -z "$PULSAR_PRESTO_CONF" ]; then
PULSAR_TRINO_CONF=$DEFAULT_PULSAR_TRINO_CONF
else
PULSAR_TRINO_CONF=$PULSAR_PRESTO_CONF
fi
fi
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #17062: [build][sql] Make pulsar-trino-disto self-contained
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #17062:
URL: https://github.com/apache/pulsar/pull/17062#issuecomment-1234978471
ping @codelipenghui @eolivelli @maxsxu @nodece @lhotari as you voted for this PIP >_<
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #17062: [build][sql] Make pulsar-trino-disto self-contained
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #17062:
URL: https://github.com/apache/pulsar/pull/17062#issuecomment-1240037447
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #17062: [build][sql] Make pulsar-trino-disto self-contained
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #17062:
URL: https://github.com/apache/pulsar/pull/17062#issuecomment-1240168751
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #17062: [build][sql] Make pulsar-trino-disto self-contained
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #17062:
URL: https://github.com/apache/pulsar/pull/17062#issuecomment-1242274797
Finally!
@codelipenghui @nicoloboschi could you help with merging this XD
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on a diff in pull request #17062: [build][sql] Make pulsar-trino-disto self-contained
Posted by GitBox <gi...@apache.org>.
tisonkun commented on code in PR #17062:
URL: https://github.com/apache/pulsar/pull/17062#discussion_r954806683
##########
distribution/server/src/assemble/bin.xml:
##########
@@ -23,6 +23,7 @@
xsi:schemaLocation="http://maven.apache.org/ASSEMBLY/2.1.0 http://maven.apache.org/xsd/assembly-2.1.0.xsd">
<id>bin</id>
<formats>
+ <format>dir</format>
Review Comment:
Reverted. Also, finish `lib/presto` to `trino` migration and test locally with examples. Don't run all integration tests though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #17062: [build][sql] Make pulsar-trino-disto self-contained
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #17062:
URL: https://github.com/apache/pulsar/pull/17062#issuecomment-1236870491
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #17062: [build][sql] Make pulsar-trino-disto self-contained
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #17062:
URL: https://github.com/apache/pulsar/pull/17062#issuecomment-1240187216
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on a diff in pull request #17062: [build][sql] Make pulsar-trino-disto self-contained
Posted by GitBox <gi...@apache.org>.
tisonkun commented on code in PR #17062:
URL: https://github.com/apache/pulsar/pull/17062#discussion_r947676029
##########
buildtools/src/main/resources/pulsar/checkstyle.xml:
##########
@@ -39,6 +39,9 @@ page at http://checkstyle.sourceforge.net/config.html -->
<property name="max" value="120"/>
<property name="severity" value="error"/>
+ <!-- Checks only for Java files. -->
+ <property name="fileExtensions" value="java"/>
Review Comment:
OK. I include this change in the patch because after I move config files under the module, this rule takes effect and reports failure. I can do it in a separate PR though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on a diff in pull request #17062: [build][sql] Make pulsar-trino-disto self-contained
Posted by GitBox <gi...@apache.org>.
tisonkun commented on code in PR #17062:
URL: https://github.com/apache/pulsar/pull/17062#discussion_r949243206
##########
buildtools/src/main/resources/pulsar/checkstyle.xml:
##########
@@ -39,6 +39,9 @@ page at http://checkstyle.sourceforge.net/config.html -->
<property name="max" value="120"/>
<property name="severity" value="error"/>
+ <!-- Checks only for Java files. -->
+ <property name="fileExtensions" value="java"/>
Review Comment:
See https://github.com/apache/pulsar/pull/17168.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on a diff in pull request #17062: [build][sql] Make pulsar-trino-disto self-contained
Posted by GitBox <gi...@apache.org>.
tisonkun commented on code in PR #17062:
URL: https://github.com/apache/pulsar/pull/17062#discussion_r959533674
##########
bin/pulsar:
##########
@@ -177,17 +177,23 @@ if [ ! -f "${PY_INSTANCE_FILE}" ]; then
PY_INSTANCE_FILE=${BUILT_PY_INSTANCE_FILE}
fi
-# find pulsar sql presto distribution location
-check_presto_libraries() {
- if [ ! -d "${PRESTO_HOME}" ]; then
-
- BUILT_PRESTO_HOME="${SQL_HOME}/presto-distribution/target/pulsar-presto-distribution"
- if [ ! -d "${BUILT_PRESTO_HOME}" ]; then
- echo "\nCouldn't find presto distribution.";
- echo "Make sure you've run 'mvn package'\n";
- exit 1;
+# find pulsar sql trino distribution location
+check_trino_libraries() {
+ if [ ! -d "${TRINO_HOME}" ]; then
+ # TODO: As PIP-200 accepted, this compatibility is not promised. Refactor when we drop this b/w compatibility.
+ FALLBACK_PRESTO_HOME="${PULSAR_HOME}/lib/presto"
Review Comment:
Revert at 54fb61e330d2bc963234727e53b3440c651906ae
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on a diff in pull request #17062: [build][sql] Make pulsar-trino-disto self-contained
Posted by GitBox <gi...@apache.org>.
tisonkun commented on code in PR #17062:
URL: https://github.com/apache/pulsar/pull/17062#discussion_r959381534
##########
bin/pulsar:
##########
@@ -257,8 +257,8 @@ if [ -z "$PULSAR_LOG_CONF" ]; then
PULSAR_LOG_CONF=$DEFAULT_LOG_CONF
fi
-if [ -z "$PULSAR_PRESTO_CONF" ]; then
- PULSAR_PRESTO_CONF=$DEFAULT_PULSAR_PRESTO_CONF
+if [ -z "$PULSAR_TRINO_CONF" ]; then
Review Comment:
Implemented in 43c8c7da41154289baf4fd26e568ce2ace4ae451.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on a diff in pull request #17062: [build][sql] Make pulsar-trino-disto self-contained
Posted by GitBox <gi...@apache.org>.
tisonkun commented on code in PR #17062:
URL: https://github.com/apache/pulsar/pull/17062#discussion_r959417237
##########
bin/pulsar:
##########
@@ -177,17 +177,23 @@ if [ ! -f "${PY_INSTANCE_FILE}" ]; then
PY_INSTANCE_FILE=${BUILT_PY_INSTANCE_FILE}
fi
-# find pulsar sql presto distribution location
-check_presto_libraries() {
- if [ ! -d "${PRESTO_HOME}" ]; then
-
- BUILT_PRESTO_HOME="${SQL_HOME}/presto-distribution/target/pulsar-presto-distribution"
- if [ ! -d "${BUILT_PRESTO_HOME}" ]; then
- echo "\nCouldn't find presto distribution.";
- echo "Make sure you've run 'mvn package'\n";
- exit 1;
+# find pulsar sql trino distribution location
+check_trino_libraries() {
+ if [ ! -d "${TRINO_HOME}" ]; then
+ # TODO: As PIP-200 accepted, this compatibility is not promised. Refactor when we drop this b/w compatibility.
+ FALLBACK_PRESTO_HOME="${PULSAR_HOME}/lib/presto"
Review Comment:
Concretely, <= 2.11 works with prestosql 334 or 333 under lib/presto, >= 2.12 works with trino 353 with breaking changes.
By no means one uses 2.12 wants to "fallback" to the previous lib folder.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #17062: [build][sql] Make pulsar-trino-disto self-contained
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #17062:
URL: https://github.com/apache/pulsar/pull/17062#issuecomment-1240467916
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #17062: [build][sql] Make pulsar-trino-disto self-contained
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #17062:
URL: https://github.com/apache/pulsar/pull/17062#issuecomment-1240284560
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #17062: [build][sql] Make pulsar-trino-disto self-contained
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #17062:
URL: https://github.com/apache/pulsar/pull/17062#issuecomment-1240663938
@nicoloboschi I think the unrequired check status is due to your action. Do you think it's good to merge this PR now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #17062: [build][sql] Make pulsar-trino-disto self-contained
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #17062:
URL: https://github.com/apache/pulsar/pull/17062#issuecomment-1211965740
Seems good. Let me handle all the remaining renaming things and try to prepare a PIP.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on a diff in pull request #17062: [build][sql] Make pulsar-trino-disto self-contained
Posted by GitBox <gi...@apache.org>.
eolivelli commented on code in PR #17062:
URL: https://github.com/apache/pulsar/pull/17062#discussion_r947672236
##########
buildtools/src/main/resources/pulsar/checkstyle.xml:
##########
@@ -39,6 +39,9 @@ page at http://checkstyle.sourceforge.net/config.html -->
<property name="max" value="120"/>
<property name="severity" value="error"/>
+ <!-- Checks only for Java files. -->
+ <property name="fileExtensions" value="java"/>
Review Comment:
this should be a separate PR
##########
distribution/server/src/assemble/bin.xml:
##########
@@ -23,6 +23,7 @@
xsi:schemaLocation="http://maven.apache.org/ASSEMBLY/2.1.0 http://maven.apache.org/xsd/assembly-2.1.0.xsd">
<id>bin</id>
<formats>
+ <format>dir</format>
Review Comment:
this looks like only convenient for debugging purposes. please remove.
the Pulsar repo is already huge when you build it (more than 5GB)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #17062: [build][sql] Make pulsar-trino-disto self-contained
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #17062:
URL: https://github.com/apache/pulsar/pull/17062#issuecomment-1238887487
It seems broker group 2 tests don't like me, lol. Update branch and rerun.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #17062: [build][sql] Make pulsar-trino-disto self-contained
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #17062:
URL: https://github.com/apache/pulsar/pull/17062#issuecomment-1236793226
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #17062: [build][sql] Make pulsar-trino-disto self-contained
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #17062:
URL: https://github.com/apache/pulsar/pull/17062#issuecomment-1240140418
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org