[GitHub] [incubator-superset] khtruong opened a new pull request #7086: WIP: Enable color consistency in a dashboard (Need to add unit tests)

[GitBox <gi...@apache.org>]

khtruong opened a new pull request #7086: WIP: Enable color consistency in a dashboard (Need to add unit tests)
URL: https://github.com/apache/incubator-superset/pull/7086
 
 
   We want color consistency so that when users revisit dashboards, colors remain the same for metrics.
   
   Currently, we follow a general algorithm to assign colors to metrics but it can lead to inconsistency. The user first picks a color scheme. Then we iterate through the list of data values and assign a color to it in a sequential manner. The color assignments are stored for the current session. If more values are added, we continue down the list of colors that are part of the scheme. If a user removes a value, all the other values keep their color association because we have stored this information. When the user saves the chart or dashboard, we do not save the color assignments. Thus when the user revisits the chart or dashboard, the color assignments may change because it iterates through the values displayed in the chart or dashboard and re-assigns their colors again. This can cause some confusion when users revisit their visualizations.
   
   This PR enforces color consistency in dashboards so that when users revisit dashboards, the same colors are applied to metrics on each visit. Note that this will not apply until the owner edits his or her dashboard and selects/saves a color scheme.
   
   I am putting out a PR while I add unit tests.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org