[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8032: fs/vfs: add missed truncate callback at timerfd file_operation

[GitBox <gi...@apache.org>]

xiaoxiang781216 commented on code in PR #8032:
URL: https://github.com/apache/nuttx/pull/8032#discussion_r1062450670


##########
fs/vfs/fs_timerfd.c:
##########
@@ -111,8 +111,12 @@ static const struct file_operations g_timerfd_fops =
   NULL,          /* write */
   NULL,          /* seek */
   NULL,          /* ioctl */
+  NULL,          /* truncate */
 #ifdef CONFIG_TIMER_FD_POLL
   timerfd_poll   /* poll */
+#else

Review Comment:
   don't need else



##########
fs/vfs/fs_timerfd.c:
##########
@@ -111,8 +111,12 @@ static const struct file_operations g_timerfd_fops =
   NULL,          /* write */
   NULL,          /* seek */
   NULL,          /* ioctl */
+  NULL,          /* truncate */

Review Comment:
   need add another NULL for mmap



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org