You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "Quanlong Huang (Jira)" <ji...@apache.org> on 2021/05/07 12:23:00 UTC
[jira] [Commented] (IMPALA-10690) Unreachable code in SSL
certificate check logic
[ https://issues.apache.org/jira/browse/IMPALA-10690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17340771#comment-17340771 ]
Quanlong Huang commented on IMPALA-10690:
-----------------------------------------
Feel free to submit a patch. Those are old codes introduced in the initial patch of IMPALA-3159. It worths investigating whether thrift already supported it, or whether we can contribute it back to thrift.
CC [~csringhofer]
> Unreachable code in SSL certificate check logic
> -----------------------------------------------
>
> Key: IMPALA-10690
> URL: https://issues.apache.org/jira/browse/IMPALA-10690
> Project: IMPALA
> Issue Type: Improvement
> Components: Infrastructure
> Affects Versions: Impala 4.0
> Reporter: Fifteen
> Assignee: Fifteen
> Priority: Trivial
>
> Hi,
> There is an unreachable branch in `TSSLSocketWithWildcardSAN #73`s
> ```
> # Line73: This branch will never be reached
> raise TTransportException(
> type=TTransportException.UNKNOWN,
> message='Could not validate SSL certificate from '
> 'host "%s". Cert=%s' % (self.host, cert))
> ```
> Can I fix it ?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org