You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2022/10/25 12:04:36 UTC
[GitHub] [incubator-eventmesh] haihuiyang opened a new issue, #1848: Possible null pointer dereference due to return value of called method [AsyncSubscribe][Enhancement] Enhancement title
haihuiyang opened a new issue, #1848:
URL: https://github.com/apache/incubator-eventmesh/issues/1848
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/eventmesh/issues?q=is%3Aissue) and found no similar issues.
### Enhancement Request
@Override
public Optional<CloudEvent> handle(CloudEvent msg) {
String content = new String(msg.getData().toBytes(), StandardCharsets.UTF_8);
log.info("receive async msg: {}|{}", msg, content);
return Optional.empty();
}
located at:
org/apache/eventmesh/tcp/demo/sub/cloudevents/AsyncSubscribe.java line 71
Add NPE to check for exceptions.
### Describe the solution you'd like
msg.getData() 可能为 null，直接调用 toBytes 会有 NPE；
在调用 toBytes 之前判断一下是否为空，如果为空，直接返回。
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] MajorHe1 closed issue #1848: [Enhancement]Possible null pointer dereference due to return value of called method [AsyncSubscribe]
Posted by GitBox <gi...@apache.org>.
MajorHe1 closed issue #1848: [Enhancement]Possible null pointer dereference due to return value of called method [AsyncSubscribe]
URL: https://github.com/apache/incubator-eventmesh/issues/1848
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] github-actions[bot] commented on issue #1848: Possible null pointer dereference due to return value of called method [AsyncSubscribe][Enhancement] Enhancement title
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #1848:
URL: https://github.com/apache/incubator-eventmesh/issues/1848#issuecomment-1290439000
Welcome to the Apache EventMesh (incubating) community!!
We are glad that you are contributing by opening this issue. :D
Please make sure to include all the relevant context.
We will be here shortly.
If you are interested in contributing to our project, please let us know!
You can check out our contributing guide on [contributing to EventMesh](https://github.com/apache/incubator-eventmesh/blob/develop/CONTRIBUTING.md).
Want to get closer to the community?
WeChat Group：
Mailing Lists:
| Name | Description |Subscribe |Unsubscribe|Archive
| ---- | ---- |---- | ---- | ---- |
|Users |User support and questions mailing list| [Subscribe](mailto:users-subscribe@eventmesh.incubator.apache.org) |[Unsubscribe](mailto:users-unsubscribe@eventmesh.incubator.apache.org) |[Mail Archives](https://lists.apache.org/list.html?users@eventmesh.apache.org)|
|Development |Development related discussions| [Subscribe](mailto:dev-subscribe@eventmesh.incubator.apache.org) |[Unsubscribe](mailto:dev-unsubscribe@eventmesh.incubator.apache.org) |[Mail Archives](https://lists.apache.org/list.html?dev@eventmesh.apache.org)|
|Commits |All commits to repositories| [Subscribe](mailto:commits-subscribe@eventmesh.incubator.apache.org) |[Unsubscribe](mailto:commits-unsubscribe@eventmesh.incubator.apache.org) |[Mail Archives](https://lists.apache.org/list.html?commits@eventmesh.apache.org)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org