You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "alex-stiff (via GitHub)" <gi...@apache.org> on 2026/06/03 14:40:41 UTC
[PR] Fix grid view topological sort for cross-group dependencies [airflow]
alex-stiff opened a new pull request, #67964:
URL: https://github.com/apache/airflow/pull/67964
When specifying group dependencies like `first_stage.end >> second_stage.start`, the ordering within the Airflow UI does not respect the default `topological` sorting.
Minimal DAG to reproduce:
```python
from datetime import datetime
from airflow.sdk import DAG, task, TaskGroup
@task
def noop_task():
pass
with DAG("grid_sort_bug_repro", start_date=datetime(2024, 1, 1), schedule=None, catchup=False):
with TaskGroup("stage_b"):
b_start = noop_task()
b_end = noop_task()
b_start >> b_end
with TaskGroup("stage_a"):
a_start = noop_task()
a_end = noop_task()
a_start >> a_end
b_end >> a_start # task-level dep, bypasses group-level relationship
```
This shows in the grid view UI as:
```
stage_a
stage_b
```
Which is alphabetical, rather than the desired `stage_b` coming before `stage_a`.
This is happening because the `_project_child_deps` function only checks `child.upstream_task_ids` populated explicitly. We need to also scan the `upstream_task_ids` of the TaskGroup's root tasks so that the tasks within the group are also visible to this function.
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull request.
Write a good git commit message following this guide: http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the documentation.
Feel free to ping (in general) for the review if you do not see reaction for a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR, please
change below checkbox to `[X]` followed by the name of the tool, uncomment the "Generated-by".
-->
- [ ] Yes (please specify the tool below)
<!--
Generated-by: [Tool Name] following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment: `{pr_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). You can add this file in a follow-up commit after the PR is created so you know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix grid view topological sort for cross-group dependencies [airflow]
Posted by "alex-stiff (via GitHub)" <gi...@apache.org>.
alex-stiff commented on PR #67964:
URL: https://github.com/apache/airflow/pull/67964#issuecomment-4741974316
> Please add unit tests covering it.
Thank you, added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix grid view topological sort for cross-group dependencies [airflow]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #67964:
URL: https://github.com/apache/airflow/pull/67964#issuecomment-4613551922
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our [Contributors' Guide](https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:
- Pay attention to the quality of your code (ruff, mypy and type annotations). Our [prek-hooks]( https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst#prerequisites-for-prek-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/airflow-core/docs/howto/custom-operator.rst) Consider adding an example Dag that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/dev/breeze/doc/README.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#coding-style-and-best-practices).
- Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix grid view topological sort for cross-group dependencies [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #67964:
URL: https://github.com/apache/airflow/pull/67964#issuecomment-4916771823
> [!NOTE]
> **๐ ๏ธ Maintainer triage note for @alex-stiff** ยท by `@potiuk` ยท 2026-07-08 16:05 UTC
>
> This draft has been inactive for ~20 days, so I'm closing it to keep the review queue tidy โ no judgment on the work itself.
>
> **No rush** โ reopen it (or open a fresh PR) whenever you're ready to continue; nothing is lost.
>
> <sub>_Automated triage โ may be imperfect; a maintainer takes the next look._</sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix grid view topological sort for cross-group dependencies [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk closed pull request #67964: Fix grid view topological sort for cross-group dependencies
URL: https://github.com/apache/airflow/pull/67964
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix grid view topological sort for cross-group dependencies [airflow]
Posted by "alex-stiff (via GitHub)" <gi...@apache.org>.
alex-stiff commented on PR #67964:
URL: https://github.com/apache/airflow/pull/67964#issuecomment-4916845545
@potiuk would you mind reopening this for me please, I don't seem to have perms! Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org