You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "jackwener (via GitHub)" <gi...@apache.org> on 2023/02/23 04:47:25 UTC
[GitHub] [arrow-datafusion] jackwener opened a new pull request, #5369: minor: disable tpcds-q41 due to not support decorrelate disjunction subquery
jackwener opened a new pull request, #5369:
URL: https://github.com/apache/arrow-datafusion/pull/5369
# Which issue does this PR close?
related #5368 .
# Rationale for this change
# What changes are included in this PR?
disable tpcds-q41
# Are these changes tested?
N/A
# Are there any user-facing changes?
N/A
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] jackwener commented on a diff in pull request #5369: minor: disable tpcds-q41 due to not support decorrelate disjunction subquery
Posted by "jackwener (via GitHub)" <gi...@apache.org>.
jackwener commented on code in PR #5369:
URL: https://github.com/apache/arrow-datafusion/pull/5369#discussion_r1115703703
##########
datafusion/core/tests/tpcds_planning.rs:
##########
@@ -320,6 +320,7 @@ async fn tpcds_logical_q57() -> Result<()> {
}
#[tokio::test]
+#[ignore] // decorrelate disjunction decorrelate subquery isn't supported.
Review Comment:
> I recommend putting a link to #5368 in the comment as well so this is easier to find / reneable
Great idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ursabot commented on pull request #5369: minor: disable tpcds-q41 due to not support decorrelate disjunction subquery
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #5369:
URL: https://github.com/apache/arrow-datafusion/pull/5369#issuecomment-1442863158
Benchmark runs are scheduled for baseline = 095f9348455880e6169c09a7c02edfe231aac59a and contender = 1309267e713523bc5d1c23e34dcc934d6d30c22b. 1309267e713523bc5d1c23e34dcc934d6d30c22b is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/3c17863937f24362943bbe5335b978c5...fe597f8bef07496c91eef65a7fc1d67d/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/5290c1fb26fa446a9d6f0ee5290bdf43...4100fc4c6bbf439d81b902712a6d6f35/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/4a15ac8c6d0f4d8daac8662b37b6682d...cb473aa7e9cd4b11a162f45840120ac2/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/3c939037d9c743e3934f918227b41062...c73067073a084f68b8c88bac8ae50e7a/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #5369: minor: disable tpcds-q41 due to not support decorrelate disjunction subquery
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #5369:
URL: https://github.com/apache/arrow-datafusion/pull/5369#discussion_r1115679257
##########
datafusion/core/tests/tpcds_planning.rs:
##########
@@ -320,6 +320,7 @@ async fn tpcds_logical_q57() -> Result<()> {
}
#[tokio::test]
+#[ignore] // decorrelate disjunction decorrelate subquery isn't supported.
Review Comment:
is the issue that when we turn on "skip failed optimizer rules" this query errors?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] jackwener merged pull request #5369: minor: disable tpcds-q41 due to not support decorrelate disjunction subquery
Posted by "jackwener (via GitHub)" <gi...@apache.org>.
jackwener merged PR #5369:
URL: https://github.com/apache/arrow-datafusion/pull/5369
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #5369: minor: disable tpcds-q41 due to not support decorrelate disjunction subquery
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #5369:
URL: https://github.com/apache/arrow-datafusion/pull/5369#discussion_r1115680185
##########
datafusion/core/tests/tpcds_planning.rs:
##########
@@ -320,6 +320,7 @@ async fn tpcds_logical_q57() -> Result<()> {
}
#[tokio::test]
+#[ignore] // decorrelate disjunction decorrelate subquery isn't supported.
Review Comment:
I recommend putting a link to https://github.com/apache/arrow-datafusion/issues/5368 in the comment as well so this is easier to find / reneable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] jackwener closed pull request #5369: minor: disable tpcds-q41 due to not support decorrelate disjunction subquery
Posted by "jackwener (via GitHub)" <gi...@apache.org>.
jackwener closed pull request #5369: minor: disable tpcds-q41 due to not support decorrelate disjunction subquery
URL: https://github.com/apache/arrow-datafusion/pull/5369
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org