You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/04/13 09:29:15 UTC

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #6743: feature: jsonrpc4j plugin

kezhenxu94 commented on a change in pull request #6743:
URL: https://github.com/apache/skywalking/pull/6743#discussion_r612285607



##########
File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/context/tag/Tags.java
##########
@@ -102,6 +102,8 @@ private Tags() {
 
     public static final String VAL_LOCAL_SPAN_AS_LOGIC_ENDPOINT = "{\"logic-span\":true}";
 
+    public static final StringTag JSON_RPC_METHOD = new StringTag(1, "jsonrpc.method");

Review comment:
       We usually only put general tags into `apm-agent-core` module, maybe you should consider moving this tag into a `Constants` util class in the `jsonrpc4j` module.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org