You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by muratsu <gi...@git.apache.org> on 2015/05/19 23:42:45 UTC
[GitHub] cordova-windows pull request: CB-9045 Create a new solution for Wi...
GitHub user muratsu opened a pull request:
https://github.com/apache/cordova-windows/pull/78
CB-9045 Create a new solution for Win10/Dev15
Currently in dev12 solution we're using shared project. The shared project has some logic that doesn't work with windows10 projects. (This is due to version changes we have from 8, 8.1 to 10.X.Y.Z)
It looks like the best option we have is to seperate out win10 to a new solution.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-windows CB-9045
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-windows/pull/78.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #78
----
commit 416b99e2fbf1ad55ac5362405e2a4a52f9ee12c0
Author: Murat Sutunc <su...@gmail.com>
Date: 2015-05-19T21:39:19Z
CB-9045 Create a new solution for Win10/Dev15
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: CB-9045 Create a new solution for Wi...
Posted by nikhilkh <gi...@git.apache.org>.
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/78#discussion_r30716069
--- Diff: template/CordovaApp.Windows10.jsproj ---
@@ -86,12 +93,11 @@
<Content Include="WinJS\js\WinJS.js" />
<None Include="WinJS\js\WinJS.intellisense.js" />
<None Include="WinJS\js\WinJS.intellisense-setup.js" />
- <None Include="CordovaApp_TemporaryKey.pfx" />
</ItemGroup>
- <Import Project="CordovaApp.projitems" Label="Shared" />
+ <Import Project="CordovaApp.projitems" />
--- End diff --
Is removing `Label="Shared"` intentional?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: CB-9045 Create a new solution for Wi...
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-windows/pull/78#issuecomment-103682040
Does it make sense to continue to support `cordova platform add windows` in this case? or should we add `cordova platform add windows10` ?
I for one prefer separation of concerns. It seems to me we are jamming everything inside the `windows` platform which leads to multiple new cl flags so we can pull them back apart...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: CB-9045 Create a new solution for Wi...
Posted by muratsu <gi...@git.apache.org>.
Github user muratsu commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/78#discussion_r30723083
--- Diff: template/CordovaApp.Windows10.jsproj ---
@@ -86,12 +93,11 @@
<Content Include="WinJS\js\WinJS.js" />
<None Include="WinJS\js\WinJS.intellisense.js" />
<None Include="WinJS\js\WinJS.intellisense-setup.js" />
- <None Include="CordovaApp_TemporaryKey.pfx" />
</ItemGroup>
- <Import Project="CordovaApp.projitems" Label="Shared" />
+ <Import Project="CordovaApp.projitems" />
--- End diff --
I dont think we actually use this label but added back to make sure we dont break anything
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: CB-9045 Create a new solution for Wi...
Posted by muratsu <gi...@git.apache.org>.
Github user muratsu commented on the pull request:
https://github.com/apache/cordova-windows/pull/78#issuecomment-103681444
UAP and SharedProj dont play nice on VisualStudio13. My understanding is, in order to have backwards compat we need to split UAP from SharedProj. This provides a better user experience for both VS15 and VS13. Please note that this doesn't affect `cordova` commands much (very slight change in win10 jsproj) and is mostly for a better IDE experience.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: CB-9045 Create a new solution for Wi...
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-windows/pull/78#issuecomment-103679656
Is this the 'new' way, or is this a temporary step on the road to 10?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: CB-9045 Create a new solution for Wi...
Posted by nikhilkh <gi...@git.apache.org>.
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-windows/pull/78#issuecomment-103932432
LGTM. I prefer the revised version which ends up with only a single solution file. Consider squashing the two commits before merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: CB-9045 Create a new solution for Wi...
Posted by muratsu <gi...@git.apache.org>.
Github user muratsu commented on the pull request:
https://github.com/apache/cordova-windows/pull/78#issuecomment-103709357
Hmm you're right on seperation of concerns. Having a new solution file isn't really a good solution to this problem. I think I have a workaround that will work with vs2013 - I'll send an update.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: CB-9045 Create a new solution for Wi...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-windows/pull/78
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org