You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/06/24 05:55:57 UTC

[GitHub] [spark] gengliangwang commented on pull request #28781: [SPARK-31953][SS] Add Spark Structured Streaming History Server Support

gengliangwang commented on pull request #28781:
URL: https://github.com/apache/spark/pull/28781#issuecomment-648607182


   @uncleGen Thanks for the work!
   I think the major issue of this PR is that there are no related test cases. How about upload event log of streaming workload and create test cases like HistoryServerSuite
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org