You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2021/04/02 12:35:07 UTC

[GitHub] [ignite-python-thin-client] ivandasch commented on a change in pull request #27: IGNITE-14465: Add the ability to set and get cluster state

ivandasch commented on a change in pull request #27:
URL: https://github.com/apache/ignite-python-thin-client/pull/27#discussion_r606216540



##########
File path: pyignite/queries/response.py
##########
@@ -44,7 +45,7 @@ def __build_header(self):
                 ('query_id', ctypes.c_longlong),
             ]
 
-            if self.protocol_version and self.protocol_version >= (1, 4, 0):
+            if self.protocol_context and self.protocol_context.is_status_flags_supported():

Review comment:
        I suppose, that check for None is ambigous here.... Let's remove it (if we are here, protocol context have been already set)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org