You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2020/10/28 08:06:35 UTC
[GitHub] [incubator-echarts] plainheart opened a new pull request #13501: fix(line): only bolder when line width in normal state is larger than 0.
plainheart opened a new pull request #13501:
URL: https://github.com/apache/incubator-echarts/pull/13501
<!-- Please fill in the following information to help us review your PR more efficiently. -->
## Brief Information
This pull request is in the type of:
- [x] bug fixing
- [ ] new feature
- [ ] others
### What does this PR do?
<!-- USE ONCE SENTENCE TO DESCRIBE WHAT THIS PR DOES. -->
Don't bolder when the line width in the normal state is 0.
### Fixed issues
N/A.
## Details
If users specify the line width in the normal state as 0, the bolder logic should be skipped.
## Usage
### Are there any API changes?
- [ ] The API has been changed.
<!-- LIST THE API CHANGES HERE -->
### Related test cases or examples to use the new APIs
See `test/line-boldWhenHover.html`
## Others
### Merging options
- [ ] Please squash the commits into a single one when merge.
### Other information
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #13501: fix(line): only bolder when line width in normal state is larger than 0.
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #13501:
URL: https://github.com/apache/incubator-echarts/pull/13501#issuecomment-717768615
Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/incubator-echarts/wiki/How-to-make-a-pull-request).
The pull request is marked to be `PR: author is committer` because you are a committer of this project.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] pissang commented on pull request #13501: fix(line): only bolder when line width in normal state is larger than 0.
Posted by GitBox <gi...@apache.org>.
pissang commented on pull request #13501:
URL: https://github.com/apache/incubator-echarts/pull/13501#issuecomment-717878366
@plainheart Or should we disable border on emphasis by default? I'm not sure which is better in a normal scenario.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #13501: fix(line): only bolder when line width in normal state is larger than 0.
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #13501:
URL: https://github.com/apache/incubator-echarts/pull/13501#issuecomment-717876607
Congratulations! Your PR has been merged. Thanks for your contribution! 👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] pissang commented on pull request #13501: fix(line): only bolder when line width in normal state is larger than 0.
Posted by GitBox <gi...@apache.org>.
pissang commented on pull request #13501:
URL: https://github.com/apache/incubator-echarts/pull/13501#issuecomment-717876445
@plainheart I think it will be definitely better. But I can't think of a general design to solve issues like this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] pissang edited a comment on pull request #13501: fix(line): only bolder when line width in normal state is larger than 0.
Posted by GitBox <gi...@apache.org>.
pissang edited a comment on pull request #13501:
URL: https://github.com/apache/incubator-echarts/pull/13501#issuecomment-717876445
@plainheart I think it will be definitely better. But I can't think of a general design to solve issues like this currently.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] plainheart commented on pull request #13501: fix(line): only bolder when line width in normal state is larger than 0.
Posted by GitBox <gi...@apache.org>.
plainheart commented on pull request #13501:
URL: https://github.com/apache/incubator-echarts/pull/13501#issuecomment-717771672
@pissang Moreover, let's have a look at another case `area-large.html`. There is only one series and its data is large, for a better visual experience, should we also avoid the `'bolder'` logic? `'bolder'` is more suitable for multiple series with the blur scope.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] pissang merged pull request #13501: fix(line): only bolder when line width in normal state is larger than 0.
Posted by GitBox <gi...@apache.org>.
pissang merged pull request #13501:
URL: https://github.com/apache/incubator-echarts/pull/13501
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org