You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2020/03/16 18:25:41 UTC

[GitHub] [incubator-gobblin] ZihanLi58 commented on a change in pull request #2925: [GOBBLIN-1080] Add configuration to add schema creation time in converter

ZihanLi58 commented on a change in pull request #2925: [GOBBLIN-1080] Add configuration to add schema creation time in converter
URL: https://github.com/apache/incubator-gobblin/pull/2925#discussion_r393228986
 
 

 ##########
 File path: gobblin-api/src/main/java/org/apache/gobblin/configuration/ConfigurationKeys.java
 ##########
 @@ -309,6 +309,8 @@
   /**
    * Converter configuration properties.
    */
+  public static final String CONVERTER_AVRO_INCLUDE_SCHEMA_CREATION_TIME = "converter.avro.include.schema.creation.time";
 
 Review comment:
   this is only a key name for the config value. Will rename it to avoid confuse.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services