You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bookkeeper.apache.org by eo...@apache.org on 2017/05/04 18:58:57 UTC
bookkeeper git commit: BOOKKEEPER-1047: Add missing error code in ZK
setData return path
Repository: bookkeeper
Updated Branches:
refs/heads/master 25c113f62 -> d5af77c05
BOOKKEEPER-1047: Add missing error code in ZK setData return path
The log warning is not printing the error code returned by ZooKeeper
Author: Matteo Merli <mm...@apache.org>
Reviewers: Enrico Olivelli <eo...@apache.org>
Closes #137 from merlimat/missing-error-msg
Project: http://git-wip-us.apache.org/repos/asf/bookkeeper/repo
Commit: http://git-wip-us.apache.org/repos/asf/bookkeeper/commit/d5af77c0
Tree: http://git-wip-us.apache.org/repos/asf/bookkeeper/tree/d5af77c0
Diff: http://git-wip-us.apache.org/repos/asf/bookkeeper/diff/d5af77c0
Branch: refs/heads/master
Commit: d5af77c05256d5942c19aff2654c5d8f5ac1eb79
Parents: 25c113f
Author: Matteo Merli <mm...@apache.org>
Authored: Thu May 4 20:58:41 2017 +0200
Committer: Enrico Olivelli <eo...@apache.org>
Committed: Thu May 4 20:58:41 2017 +0200
----------------------------------------------------------------------
.../java/org/apache/bookkeeper/meta/AbstractZkLedgerManager.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/bookkeeper/blob/d5af77c0/bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/AbstractZkLedgerManager.java
----------------------------------------------------------------------
diff --git a/bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/AbstractZkLedgerManager.java b/bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/AbstractZkLedgerManager.java
index f5a60f6..1c82e0f 100644
--- a/bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/AbstractZkLedgerManager.java
+++ b/bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/AbstractZkLedgerManager.java
@@ -398,7 +398,7 @@ abstract class AbstractZkLedgerManager implements LedgerManager, Watcher {
metadata.setVersion(zv.setZnodeVersion(stat.getVersion()));
cb.operationComplete(BKException.Code.OK, null);
} else {
- LOG.warn("Conditional update ledger metadata failed: ", KeeperException.Code.get(rc));
+ LOG.warn("Conditional update ledger metadata failed: {}", KeeperException.Code.get(rc));
cb.operationComplete(BKException.Code.ZKException, null);
}
}