You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/10/28 08:14:11 UTC

[GitHub] [spark] waitinfuture commented on a change in pull request #30168: [SPARK-33208][SQL] Update the document of SparkSession#sql

waitinfuture commented on a change in pull request #30168:
URL: https://github.com/apache/spark/pull/30168#discussion_r513249692



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala
##########
@@ -601,6 +601,7 @@ class SparkSession private(
   /**
    * Executes a SQL query using Spark, returning the result as a `DataFrame`.
    * The dialect that is used for SQL parsing can be configured with 'spark.sql.dialect'.

Review comment:
       [SPARK-28997] added this config, and [SPARK-30125] removed it. For now SparkSession.sql and SQLContext.sql's comments refer to it. I think we just need to delete it?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org