You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@deltaspike.apache.org by DennisRippinger <gi...@git.apache.org> on 2017/07/02 12:52:38 UTC

[GitHub] deltaspike pull request #74: DELTASPIKE-1278: Added an additonal check 

GitHub user DennisRippinger opened a pull request:

    https://github.com/apache/deltaspike/pull/74

    DELTASPIKE-1278: Added an additonal check 

    This PR adds an additional check to ensure that a given file url does exist. This allows the `EnvironmentPropertyConfigSourceProvider` to respect a positive optional flag. It is still to question how to handle other non `file:\\` urls. I also thought about making optional handling part of `PropertyFileUtils#loadProperties`but wasn't sure if this brings problems to other places.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/DennisRippinger/deltaspike DELTASPIKE-1278

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/deltaspike/pull/74.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #74
    
----
commit 158acc70d729328b3c507bd9809de2e5de685c1d
Author: Dennis Rippinger <de...@gmail.com>
Date:   2017-07-02T12:43:31Z

    DELTASPIKE-1278: Added an additonal check to ensure local resources do exist to respect optional flag.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] deltaspike pull request #74: DELTASPIKE-1278: Added an additonal check

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/deltaspike/pull/74


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---