You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by Joe Bowser <bo...@gmail.com> on 2015/10/16 19:35:11 UTC
Merging smores branch into Cordova-Android TODAY
Hey
I'm going to be merging the smores branch into master by 3:00 PM today.
I've left this pull request open for the past week, so we should be ready
to go. Please let me know if there's any reason I shouldn't merge this
in. Once this is merged, there will be a discuss thread for
Cordova-Android 5.0.0.
If you have a Nexus device, please update it to Marshmallow and start
testing Cordova applications and filing those issues in our JIRA. If
there's third party plugins, please let me know, and I will look at them
and see if there's any major issues with that plugin being upgraded and
will try to contact the author.
If we can be a bit more pro-active with this one to try and avoid breakage
(there shouldn't be much breakage, since most plugins don't ask for more
permissions), that would be awesome.
Thanks
Joe
Re: Merging smores branch into Cordova-Android TODAY
Posted by Joe Bowser <bo...@gmail.com>.
Changes have been merged. Going to start up a discuss thread for
Cordova-Android 5.0. We should probably keep the discuss thread for this
open a bit longer.
On Sun, Oct 18, 2015 at 6:28 PM, Nikhil Khandelwal <ni...@microsoft.com>
wrote:
> Thanks Joe!
>
> Most of the changes look good. I did leave a comment on the design of the
> CordovaPlugin base class - I don’t want to block progress on that. Feel
> free to merge it - but let's see if we can rationalize why we are adding
> the base class methods - it seems only for the Geoloc plugin - but I don’t
> know enough about this area to understand this fully.
>
> I would love to see the guidance for what changes a plugin developer
> should make to work in Marshmallow - Perhaps even giving them a link to our
> commit to fix one of the plugins.
>
> -Nikhil
>
> -----Original Message-----
> From: Joe Bowser [mailto:bowserj@gmail.com]
> Sent: Friday, October 16, 2015 2:33 PM
> To: dev <de...@cordova.apache.org>
> Subject: Re: Merging smores branch into Cordova-Android TODAY
>
> I guess that I'm going to have to write the blog post for this release,
> including how permissions work on Android.
>
> On Fri, Oct 16, 2015 at 11:36 AM, Parashuram N <pa...@microsoft.com>
> wrote:
>
> > As discussed in the Cordova Face to Face yesterday, we said that we
> > want our users to be aware of changes like these that will hit them.
> > Is someone looking at writing a blog post for this ?
> >
> > -----Original Message-----
> > From: Joe Bowser [mailto:bowserj@gmail.com]
> > Sent: Friday, October 16, 2015 10:35 AM
> > To: dev <de...@cordova.apache.org>
> > Subject: Merging smores branch into Cordova-Android TODAY
> >
> > Hey
> >
> > I'm going to be merging the smores branch into master by 3:00 PM today.
> > I've left this pull request open for the past week, so we should be
> > ready to go. Please let me know if there's any reason I shouldn't
> > merge this in. Once this is merged, there will be a discuss thread
> > for Cordova-Android 5.0.0.
> >
> > If you have a Nexus device, please update it to Marshmallow and start
> > testing Cordova applications and filing those issues in our JIRA. If
> > there's third party plugins, please let me know, and I will look at
> > them and see if there's any major issues with that plugin being
> > upgraded and will try to contact the author.
> >
> > If we can be a bit more pro-active with this one to try and avoid
> > breakage (there shouldn't be much breakage, since most plugins don't
> > ask for more permissions), that would be awesome.
> >
> > Thanks
> >
> > Joe
> >
>
RE: Merging smores branch into Cordova-Android TODAY
Posted by Nikhil Khandelwal <ni...@microsoft.com>.
Thanks Joe!
Most of the changes look good. I did leave a comment on the design of the CordovaPlugin base class - I don’t want to block progress on that. Feel free to merge it - but let's see if we can rationalize why we are adding the base class methods - it seems only for the Geoloc plugin - but I don’t know enough about this area to understand this fully.
I would love to see the guidance for what changes a plugin developer should make to work in Marshmallow - Perhaps even giving them a link to our commit to fix one of the plugins.
-Nikhil
-----Original Message-----
From: Joe Bowser [mailto:bowserj@gmail.com]
Sent: Friday, October 16, 2015 2:33 PM
To: dev <de...@cordova.apache.org>
Subject: Re: Merging smores branch into Cordova-Android TODAY
I guess that I'm going to have to write the blog post for this release, including how permissions work on Android.
On Fri, Oct 16, 2015 at 11:36 AM, Parashuram N <pa...@microsoft.com>
wrote:
> As discussed in the Cordova Face to Face yesterday, we said that we
> want our users to be aware of changes like these that will hit them.
> Is someone looking at writing a blog post for this ?
>
> -----Original Message-----
> From: Joe Bowser [mailto:bowserj@gmail.com]
> Sent: Friday, October 16, 2015 10:35 AM
> To: dev <de...@cordova.apache.org>
> Subject: Merging smores branch into Cordova-Android TODAY
>
> Hey
>
> I'm going to be merging the smores branch into master by 3:00 PM today.
> I've left this pull request open for the past week, so we should be
> ready to go. Please let me know if there's any reason I shouldn't
> merge this in. Once this is merged, there will be a discuss thread
> for Cordova-Android 5.0.0.
>
> If you have a Nexus device, please update it to Marshmallow and start
> testing Cordova applications and filing those issues in our JIRA. If
> there's third party plugins, please let me know, and I will look at
> them and see if there's any major issues with that plugin being
> upgraded and will try to contact the author.
>
> If we can be a bit more pro-active with this one to try and avoid
> breakage (there shouldn't be much breakage, since most plugins don't
> ask for more permissions), that would be awesome.
>
> Thanks
>
> Joe
>
Re: Merging smores branch into Cordova-Android TODAY
Posted by Joe Bowser <bo...@gmail.com>.
I guess that I'm going to have to write the blog post for this release,
including how permissions work on Android.
On Fri, Oct 16, 2015 at 11:36 AM, Parashuram N <pa...@microsoft.com>
wrote:
> As discussed in the Cordova Face to Face yesterday, we said that we want
> our users to be aware of changes like these that will hit them. Is someone
> looking at writing a blog post for this ?
>
> -----Original Message-----
> From: Joe Bowser [mailto:bowserj@gmail.com]
> Sent: Friday, October 16, 2015 10:35 AM
> To: dev <de...@cordova.apache.org>
> Subject: Merging smores branch into Cordova-Android TODAY
>
> Hey
>
> I'm going to be merging the smores branch into master by 3:00 PM today.
> I've left this pull request open for the past week, so we should be ready
> to go. Please let me know if there's any reason I shouldn't merge this
> in. Once this is merged, there will be a discuss thread for
> Cordova-Android 5.0.0.
>
> If you have a Nexus device, please update it to Marshmallow and start
> testing Cordova applications and filing those issues in our JIRA. If
> there's third party plugins, please let me know, and I will look at them
> and see if there's any major issues with that plugin being upgraded and
> will try to contact the author.
>
> If we can be a bit more pro-active with this one to try and avoid breakage
> (there shouldn't be much breakage, since most plugins don't ask for more
> permissions), that would be awesome.
>
> Thanks
>
> Joe
>
RE: Merging smores branch into Cordova-Android TODAY
Posted by Nikhil Khandelwal <ni...@microsoft.com>.
I think there are two aspects of the CI. I think Dmitry is handling the BuildBOT CI update to support android-23.
Travis CI need android 23 which is causing Joe's change to fail in PR state: https://travis-ci.org/apache/cordova-android/builds/83964922
Joe you need to update Travis, as part of your change. In the file, https://github.com/apache/cordova-android/blob/master/.travis.yml replace android-22 with android-23.
Thanks,
Nikhil
-----Original Message-----
From: Joe Bowser [mailto:bowserj@gmail.com]
Sent: Friday, October 16, 2015 2:41 PM
To: dev <de...@cordova.apache.org>
Subject: Re: Merging smores branch into Cordova-Android TODAY
OK, I'll push this monday.
On Fri, Oct 16, 2015 at 2:37 PM, Dmitry Blotsky <db...@microsoft.com>
wrote:
> I’m installing 23 on the CI right now. Should be done, conservatively,
> in
> 2 hours.
>
> > On Oct 16, 2015, at 1:38 PM, Joe Bowser <bo...@gmail.com> wrote:
> >
> > OK, I locally did the rebase. How soon can we get the CI to have
> > android-23 installed so that Travis no longer fails?
> >
> > On Fri, Oct 16, 2015 at 11:36 AM, Parashuram N
> > <pa...@microsoft.com>
> > wrote:
> >
> >> As discussed in the Cordova Face to Face yesterday, we said that we
> >> want our users to be aware of changes like these that will hit
> >> them. Is
> someone
> >> looking at writing a blog post for this ?
> >>
> >> -----Original Message-----
> >> From: Joe Bowser [mailto:bowserj@gmail.com]
> >> Sent: Friday, October 16, 2015 10:35 AM
> >> To: dev <de...@cordova.apache.org>
> >> Subject: Merging smores branch into Cordova-Android TODAY
> >>
> >> Hey
> >>
> >> I'm going to be merging the smores branch into master by 3:00 PM today.
> >> I've left this pull request open for the past week, so we should be
> ready
> >> to go. Please let me know if there's any reason I shouldn't merge
> >> this in. Once this is merged, there will be a discuss thread for
> >> Cordova-Android 5.0.0.
> >>
> >> If you have a Nexus device, please update it to Marshmallow and
> >> start testing Cordova applications and filing those issues in our
> >> JIRA. If there's third party plugins, please let me know, and I
> >> will look at them and see if there's any major issues with that
> >> plugin being upgraded and will try to contact the author.
> >>
> >> If we can be a bit more pro-active with this one to try and avoid
> breakage
> >> (there shouldn't be much breakage, since most plugins don't ask for
> >> more permissions), that would be awesome.
> >>
> >> Thanks
> >>
> >> Joe
> >>
>
>
Re: Merging smores branch into Cordova-Android TODAY
Posted by Joe Bowser <bo...@gmail.com>.
OK, I'll push this monday.
On Fri, Oct 16, 2015 at 2:37 PM, Dmitry Blotsky <db...@microsoft.com>
wrote:
> I’m installing 23 on the CI right now. Should be done, conservatively, in
> 2 hours.
>
> > On Oct 16, 2015, at 1:38 PM, Joe Bowser <bo...@gmail.com> wrote:
> >
> > OK, I locally did the rebase. How soon can we get the CI to have
> > android-23 installed so that Travis no longer fails?
> >
> > On Fri, Oct 16, 2015 at 11:36 AM, Parashuram N <pa...@microsoft.com>
> > wrote:
> >
> >> As discussed in the Cordova Face to Face yesterday, we said that we want
> >> our users to be aware of changes like these that will hit them. Is
> someone
> >> looking at writing a blog post for this ?
> >>
> >> -----Original Message-----
> >> From: Joe Bowser [mailto:bowserj@gmail.com]
> >> Sent: Friday, October 16, 2015 10:35 AM
> >> To: dev <de...@cordova.apache.org>
> >> Subject: Merging smores branch into Cordova-Android TODAY
> >>
> >> Hey
> >>
> >> I'm going to be merging the smores branch into master by 3:00 PM today.
> >> I've left this pull request open for the past week, so we should be
> ready
> >> to go. Please let me know if there's any reason I shouldn't merge this
> >> in. Once this is merged, there will be a discuss thread for
> >> Cordova-Android 5.0.0.
> >>
> >> If you have a Nexus device, please update it to Marshmallow and start
> >> testing Cordova applications and filing those issues in our JIRA. If
> >> there's third party plugins, please let me know, and I will look at them
> >> and see if there's any major issues with that plugin being upgraded and
> >> will try to contact the author.
> >>
> >> If we can be a bit more pro-active with this one to try and avoid
> breakage
> >> (there shouldn't be much breakage, since most plugins don't ask for more
> >> permissions), that would be awesome.
> >>
> >> Thanks
> >>
> >> Joe
> >>
>
>
Re: Merging smores branch into Cordova-Android TODAY
Posted by Dmitry Blotsky <db...@microsoft.com>.
I’m installing 23 on the CI right now. Should be done, conservatively, in 2 hours.
> On Oct 16, 2015, at 1:38 PM, Joe Bowser <bo...@gmail.com> wrote:
>
> OK, I locally did the rebase. How soon can we get the CI to have
> android-23 installed so that Travis no longer fails?
>
> On Fri, Oct 16, 2015 at 11:36 AM, Parashuram N <pa...@microsoft.com>
> wrote:
>
>> As discussed in the Cordova Face to Face yesterday, we said that we want
>> our users to be aware of changes like these that will hit them. Is someone
>> looking at writing a blog post for this ?
>>
>> -----Original Message-----
>> From: Joe Bowser [mailto:bowserj@gmail.com]
>> Sent: Friday, October 16, 2015 10:35 AM
>> To: dev <de...@cordova.apache.org>
>> Subject: Merging smores branch into Cordova-Android TODAY
>>
>> Hey
>>
>> I'm going to be merging the smores branch into master by 3:00 PM today.
>> I've left this pull request open for the past week, so we should be ready
>> to go. Please let me know if there's any reason I shouldn't merge this
>> in. Once this is merged, there will be a discuss thread for
>> Cordova-Android 5.0.0.
>>
>> If you have a Nexus device, please update it to Marshmallow and start
>> testing Cordova applications and filing those issues in our JIRA. If
>> there's third party plugins, please let me know, and I will look at them
>> and see if there's any major issues with that plugin being upgraded and
>> will try to contact the author.
>>
>> If we can be a bit more pro-active with this one to try and avoid breakage
>> (there shouldn't be much breakage, since most plugins don't ask for more
>> permissions), that would be awesome.
>>
>> Thanks
>>
>> Joe
>>
Re: Merging smores branch into Cordova-Android TODAY
Posted by Joe Bowser <bo...@gmail.com>.
OK, I locally did the rebase. How soon can we get the CI to have
android-23 installed so that Travis no longer fails?
On Fri, Oct 16, 2015 at 11:36 AM, Parashuram N <pa...@microsoft.com>
wrote:
> As discussed in the Cordova Face to Face yesterday, we said that we want
> our users to be aware of changes like these that will hit them. Is someone
> looking at writing a blog post for this ?
>
> -----Original Message-----
> From: Joe Bowser [mailto:bowserj@gmail.com]
> Sent: Friday, October 16, 2015 10:35 AM
> To: dev <de...@cordova.apache.org>
> Subject: Merging smores branch into Cordova-Android TODAY
>
> Hey
>
> I'm going to be merging the smores branch into master by 3:00 PM today.
> I've left this pull request open for the past week, so we should be ready
> to go. Please let me know if there's any reason I shouldn't merge this
> in. Once this is merged, there will be a discuss thread for
> Cordova-Android 5.0.0.
>
> If you have a Nexus device, please update it to Marshmallow and start
> testing Cordova applications and filing those issues in our JIRA. If
> there's third party plugins, please let me know, and I will look at them
> and see if there's any major issues with that plugin being upgraded and
> will try to contact the author.
>
> If we can be a bit more pro-active with this one to try and avoid breakage
> (there shouldn't be much breakage, since most plugins don't ask for more
> permissions), that would be awesome.
>
> Thanks
>
> Joe
>
RE: Merging smores branch into Cordova-Android TODAY
Posted by Parashuram N <pa...@microsoft.com>.
As discussed in the Cordova Face to Face yesterday, we said that we want our users to be aware of changes like these that will hit them. Is someone looking at writing a blog post for this ?
-----Original Message-----
From: Joe Bowser [mailto:bowserj@gmail.com]
Sent: Friday, October 16, 2015 10:35 AM
To: dev <de...@cordova.apache.org>
Subject: Merging smores branch into Cordova-Android TODAY
Hey
I'm going to be merging the smores branch into master by 3:00 PM today.
I've left this pull request open for the past week, so we should be ready to go. Please let me know if there's any reason I shouldn't merge this in. Once this is merged, there will be a discuss thread for Cordova-Android 5.0.0.
If you have a Nexus device, please update it to Marshmallow and start testing Cordova applications and filing those issues in our JIRA. If there's third party plugins, please let me know, and I will look at them and see if there's any major issues with that plugin being upgraded and will try to contact the author.
If we can be a bit more pro-active with this one to try and avoid breakage (there shouldn't be much breakage, since most plugins don't ask for more permissions), that would be awesome.
Thanks
Joe