You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/12/16 21:53:17 UTC

[GitHub] [incubator-superset] nytai edited a comment on pull request #12081: feat: update alert/report icons and column order

nytai edited a comment on pull request #12081:
URL: https://github.com/apache/incubator-superset/pull/12081#issuecomment-747062783


   Actually, they all look the same size in the designs 
   <img width="341" alt="Screen Shot 2020-12-16 at 1 48 59 PM" src="https://user-images.githubusercontent.com/10255196/102410542-8b0d7200-3fa5-11eb-8f25-5d313083bbb5.png">
   
   We should either add another variant of the icon `alert-solid-small` like we do with other icons or we can apply a `width` and `height` (and maybe `position`) styles. The figma mocks have `width: 12px; height: 12px;` applied to the icon
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org