[ofbiz-framework] branch release17.12 updated: Fixed: MessagingException in sendShipmentScheduledNotification service (OFBIZ-11984)

[jl...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

jleroux pushed a commit to branch release17.12
in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git


The following commit(s) were added to refs/heads/release17.12 by this push:
     new 3cfed4c  Fixed: MessagingException in sendShipmentScheduledNotification service (OFBIZ-11984)
3cfed4c is described below

commit 3cfed4c657e28f37177a32b4fc7e504b25675160
Author: Jacques Le Roux <ja...@les7arts.com>
AuthorDate: Wed Aug 26 19:53:08 2020 +0200

    Fixed: MessagingException in sendShipmentScheduledNotification service (OFBIZ-11984)
    
    This MessagingException issue is with sendFrom, please refer the the code blocks from minilang and groovy versions below,
    
    <!-- find email address for currently logged in user, set as sendFrom -->
    <entity-and entity-name="PartyAndContactMech" list="curUserPartyAndContactMechs">
        <field-map field-name="partyId" from-field="userLogin.partyId"/>
        <field-map field-name="contactMechTypeId" value="EMAIL_ADDRESS"/>
    </entity-and>
    
    <first-from-list list="curUserPartyAndContactMechs" entry="curUserPartyAndContactMech"/>
    <string-append field="sendEmailMap.sendFrom" string="${curUserPartyAndContactMech.infoString}" prefix=","/>
    
    There should not be a prefix, there is always only 1 sender
    sendOrderDeliveryScheduleNotification was also affected
    
    Thanks: Mridul Pathak for analyse
---
 applications/order/minilang/order/OrderDeliveryServices.xml          | 2 +-
 applications/product/minilang/shipment/shipment/ShipmentServices.xml | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/applications/order/minilang/order/OrderDeliveryServices.xml b/applications/order/minilang/order/OrderDeliveryServices.xml
index c2e04f1..6341086 100644
--- a/applications/order/minilang/order/OrderDeliveryServices.xml
+++ b/applications/order/minilang/order/OrderDeliveryServices.xml
@@ -88,7 +88,7 @@ under the License.
         <set field="curUserPcmFindMap.contactMechTypeId" value="EMAIL_ADDRESS"/>
         <find-by-and entity-name="PartyAndContactMech" map="curUserPcmFindMap" list="curUserPartyAndContactMechs"/>
         <first-from-list list="curUserPartyAndContactMechs" entry="curUserPartyAndContactMech"/>
-        <string-append field="sendEmailMap.sendFrom" string="${curUserPartyAndContactMech.infoString}" prefix=","/>
+        <string-append field="sendEmailMap.sendFrom" string="${curUserPartyAndContactMech.infoString}"/>
 
         <!-- find email addresses of all parties in SHIPMENT_CLERK roleTypeId, set as sendTo -->
         <set value="SHIPMENT_CLERK" field="shipmentClerkFindMap.roleTypeId"/>
diff --git a/applications/product/minilang/shipment/shipment/ShipmentServices.xml b/applications/product/minilang/shipment/shipment/ShipmentServices.xml
index 31cce84..d2b0d74 100644
--- a/applications/product/minilang/shipment/shipment/ShipmentServices.xml
+++ b/applications/product/minilang/shipment/shipment/ShipmentServices.xml
@@ -740,7 +740,7 @@ under the License.
         </entity-and>
 
         <first-from-list list="curUserPartyAndContactMechs" entry="curUserPartyAndContactMech"/>
-        <string-append field="sendEmailMap.sendFrom" string="${curUserPartyAndContactMech.infoString}" prefix=","/>
+        <string-append field="sendEmailMap.sendFrom" string="${curUserPartyAndContactMech.infoString}"/>
 
         <!-- find email addresses of partyIdFrom, set as sendTo -->
         <set from-field="shipment.partyIdFrom" field="sendToPartyIdMap.${shipment.partyIdFrom}"/>