You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kudu.apache.org by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org> on 2016/03/02 05:32:27 UTC

[kudu-CR](branch-0.7.x) KUDU-1360. [spark] KuduRelation.getKuduValue doesn't check nulls

Hello Todd Lipcon, Kudu Jenkins,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/2394

to review the following change.

Change subject: KUDU-1360. [spark] KuduRelation.getKuduValue doesn't check nulls
......................................................................

KUDU-1360. [spark] KuduRelation.getKuduValue doesn't check nulls

Fixes the bug and adds a small test.

We should have a "all types all options" kind of test.

Change-Id: I8bfd3144806b0b84bea00e8eec77a6ba7698379b
Reviewed-on: http://gerrit.cloudera.org:8080/2381
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon <to...@apache.org>
---
M java/kudu-spark/src/main/scala/org/kududb/spark/DefaultSource.scala
M java/kudu-spark/src/test/scala/org/kududb/spark/DefaultSourceTest.scala
M java/kudu-spark/src/test/scala/org/kududb/spark/TestContext.scala
3 files changed, 23 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/94/2394/1
-- 
To view, visit http://gerrit.cloudera.org:8080/2394
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8bfd3144806b0b84bea00e8eec77a6ba7698379b
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-0.7.x
Gerrit-Owner: Jean-Daniel Cryans
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>