You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "Pakapoj Tulsuk (Jira)" <ji...@apache.org> on 2021/06/09 07:21:00 UTC
[jira] [Comment Edited] (HDDS-5307) Two functions performing the
same logic
[ https://issues.apache.org/jira/browse/HDDS-5307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17359808#comment-17359808 ]
Pakapoj Tulsuk edited comment on HDDS-5307 at 6/9/21, 7:20 AM:
---------------------------------------------------------------
Hi [~sombat.cha] Ill change
{{checkAclRight}} to {{checkAclRights}} in {{KeyManagerImpl}} b/c it's easier
was (Author: pakapoj):
Hi [~sombat.cha] Ill change
{{checkAclRights}} to {{checkAclRight}} in {{KeyManagerImpl}} b/c it's easier
> Two functions performing the same logic
> ---------------------------------------
>
> Key: HDDS-5307
> URL: https://issues.apache.org/jira/browse/HDDS-5307
> Project: Apache Ozone
> Issue Type: Improvement
> Components: OM
> Affects Versions: 1.2.0
> Reporter: Sombat Charnchaleo
> Priority: Trivial
> Labels: patch
> Attachments: Screen Shot 2564-06-09 at 13.49.17.png, Screen Shot 2564-06-09 at 13.49.37.png
>
>
> I found there are two functions performing the same purpose and the same logic. Would like to have a review if we could reduce to only one function.
> *java source code:*
> java/org/apache/hadoop/ozone/om/helpers/OzoneAclUtil.java
> *class method:*
> checkAclRight() and checkAclRights()
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org