[GitHub] [pulsar] acortes-okode commented on pull request #16650: [improve][authentication] Support for get token from HTTP params

[GitBox <gi...@apache.org>]

acortes-okode commented on PR #16650:
URL: https://github.com/apache/pulsar/pull/16650#issuecomment-1188813828

   > You can use `mvn clean install -Pcore-modules,-main -DskipTests -Dspotbugs.skip` command to build this project.
   
   Thanks @nodece, I was able to pass the compilation problem on 'pulsar-common' but now I have others in 'managed-ledget', I think is something regarding lombok maybe since it says it cannot find some 'get' symbols. I'll try to figure out if I can later.
   
   Anyways, I was trying to build it to test something I had in mind but maybe you could know it firsthand. The thing is, I'm not sure if `AuthenticationProviderToken#newHttpAuthState` is called for every HTTP request (correct me if I'm wrong) but, if it is, then I think one could manage to authenticate to other requests rather than the WebSocket one by using the `token` request query param (also not sure if this is intended). E.g.
   
   ```sh
   curl "http://localhost:8080/admin/v2/brokers/configuration?token=ASDFGH...."
   ```
   
   Thanks in advance!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org