You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by Damien Diederen <dd...@sinenomine.net> on 2021/01/06 12:19:26 UTC

3.7.0: Last call for tickets (was: Time to Cut 3.7.0 ?)

Greetings, all,


Unless someone objects, this is a last call for tickets before I create
branches 'branch-3.7' and 'branch-3.7.0' in preparation for a new
release, aiming for a first candidate in the coming days.

Besides the tickets mentioned below, are there other patches you would
like to see included in 3.7.0?  If not, I will soon start pushing the
open tickets to 3.8.0 in Jira.

(Of course, my ticket-tagging, Git-branching, or even publishing a first
release candidate does not preclude "cherry-picking" further patches.)


I already went through (and somewhat cleaned up) these two views:

  * https://issues.apache.org/jira/projects/ZOOKEEPER/versions/12346617

  * https://issues.apache.org/jira/browse/ZOOKEEPER-3426?jql=project%20%3D%20ZOOKEEPER%20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY%20priority%20DESC%2C%20key%20ASC

We have a single remaining blocker, concerning the C client, and it is
not currently marked for 3.7.0:

  * ZOOKEEPER-3426: ZK prime_connection(the Handshake) can complete
    without reading all the payload.

(It looks nasty, though, so I will try to have a look ASAP.)

I also hope to get a green light for merging this first iteration of
quota support:

  * ZOOKEEPER-3301: Enforce the quota limit

    https://github.com/apache/zookeeper/pull/934#issuecomment-754882022


What do you think?

Cheers,
Damien Diederen

P.-S. — This is my first time as a ZooKeeper release manager, so don't
hesitate to point out any perceived or actual missteps!



Damien Diederen <dd...@sinenomine.net> writes:
> Hi Enrico, all,
>
> A Happy New Year!
>
> Yes, I am still willing to take care of 3.7.0.  I thought I would start
> once 3.5.9 was out, but I suppose there is no reason not to make
> progress in parallel.
>
> I still have to dig into the tracker and sort the list of applicable
> tickets, but was already wondering about the ones below, for which pull
> requests are more or less ready.
>
> (I really would like to include the first one, which is just stalled;
> the latter two, which are mine, are perhaps a bit "fresh.")
>
>   * ZOOKEEPER-3301:Enforce the quota limit
>     https://github.com/apache/zookeeper/pull/934
>
>   * ZOOKEEPER-4026: Complete support for Stat objects (and create2) in
>     multi requests
>     https://github.com/apache/zookeeper/pull/1559
>
>   * ZOOKEEPER-4030: Optionally canonicalize host names in quorum SASL
>     authentication
>     https://github.com/apache/zookeeper/pull/1564
>
> What do you think?
>
> I'll ping people on the individual PRs.
>
> Cheers, -D
>
>
>
> Enrico Olivelli <eo...@gmail.com> writes:
>> Hi ZooKeepers,
>> I feel it is time to deliver 3.7.0 to the public.
>>
>> Any volunteer ?
>> Probably Demien, you already told you were available for this release
>>
>> Please also remember that there is a VOTE open for 3.5.9
>>
>> Best regards and Happy new year
>> Enrico

mvn release:branch and stray @{releaseLabel} (was: 3.7.0: Last call for tickets)

Posted by Damien Diederen <dd...@sinenomine.net>.
Hi Enrico,

> Il giorno dom 10 gen 2021 alle ore 22:13 Damien Diederen <
> ddiederen@sinenomine.net> ha scritto:
>>
>> Hi Enrico, all,
>>
>> Following the instructions in "Create a branch (when you create X.Y.0
>> and move master to X.Y+1.0)" in Confluence,¹ I noticed that:
>>
>>  1. The 'mvn release:branch' command does not seem to fully interpolate
>>     commit messages; I get:
>>
>>         [maven-release-plugin] prepare branch @{releaseLabel}
>
> This is strange, which version of Maven are you using? I suggest to use
> 3.6.3

It is.

I have been using the Docker environment, and just double-checked: it is
Maven 3.6.3, as expected:

    $ mvn --version
    Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
    Maven home: /usr/share/maven
    Java version: 1.8.0_275, vendor: Oracle Corporation, runtime: /usr/local/openjdk-8/jre
    Default locale: en, platform encoding: UTF-8
    OS name: "linux", version: "5.4.0-42-generic", arch: "amd64", family: "unix"

I am seeing the same results with Maven outside of Docker…

… and looking at this code, I cannot say I am surprised:

    https://github.com/apache/maven-release/blob/761ab3b03cc3/maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractScmCommitPhase.java#L224-L231

It seems that the token which gets replaced for branches is
'@{branchName}'.  And indeed, this produces the expected result:

    mvn release:branch \
        -DbranchName=$BRANCH_NAME \
        -DdevelopmentVersion=$MASTER_DEVELOPMENT_VERSION \
        -DscmBranchCommitComment='@{prefix} prepare branch @{branchName}' \
        -Pfull-build

I may be missing something, but it looks like the template is wrong:

    https://github.com/apache/maven-release/blob/761ab3b03cc3/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/BranchReleaseMojo.java#L230-L231

This partial revert of ZOOKEEPER-3791 "fixes" it:

    --- a/pom.xml
    +++ b/pom.xml
    @@ -694,6 +694,7 @@
             <plugin>
               <groupId>org.apache.maven.plugins</groupId>
               <artifactId>maven-release-plugin</artifactId>
    +          <version>2.5.3</version>
             </plugin>

Hmm…  I suppose I'll create a ticket for reverting that specific
version, and ask upstream what is going on.

>>  2. Tags are named via "release-$RELEASE_VERSION-$RC_NUM", instead of
>>     "...-rc$RC_NUM" for 3.5+.  Is that on purpose?
>
> yes it is, already pointed out by someone, but not an issue from my point
> of view
> good catch

Okay.  Was just wondering :)

Cheers, -D

Re: 3.7.0: Last call for tickets

Posted by Enrico Olivelli <eo...@gmail.com>.
Il giorno dom 10 gen 2021 alle ore 22:13 Damien Diederen <
ddiederen@sinenomine.net> ha scritto:

>
> Hi Enrico, all,
>
> Following the instructions in "Create a branch (when you create X.Y.0
> and move master to X.Y+1.0)" in Confluence,¹ I noticed that:
>
>  1. The 'mvn release:branch' command does not seem to fully interpolate
>     commit messages; I get:
>
>         [maven-release-plugin] prepare branch @{releaseLabel}
>

This is strange, which version of Maven are you using? I suggest to use
3.6.3


>
>     I tried cargo-culting a "-DreleaseLabel=$BRANCH_NAME" in my command,
>     but that did not work.  Any tips before I dig deeper?
>
>  2. Tags are named via "release-$RELEASE_VERSION-$RC_NUM", instead of
>     "...-rc$RC_NUM" for 3.5+.  Is that on purpose?
>
yes it is, already pointed out by someone, but not an issue from my point
of view
good catch

Enrico


>
> Cheers, -D
>
> ¹
> https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToRelease+using+maven+release+plugin
>
>
>
> Damien Diederen <dd...@sinenomine.net> writes:
> > Greetings, all,
> >
> >
> > Unless someone objects, this is a last call for tickets before I create
> > branches 'branch-3.7' and 'branch-3.7.0' in preparation for a new
> > release, aiming for a first candidate in the coming days.
> >
> > Besides the tickets mentioned below, are there other patches you would
> > like to see included in 3.7.0?  If not, I will soon start pushing the
> > open tickets to 3.8.0 in Jira.
> >
> > (Of course, my ticket-tagging, Git-branching, or even publishing a first
> > release candidate does not preclude "cherry-picking" further patches.)
> >
> >
> > I already went through (and somewhat cleaned up) these two views:
> >
> >   * https://issues.apache.org/jira/projects/ZOOKEEPER/versions/12346617
> >
> >   *
> https://issues.apache.org/jira/browse/ZOOKEEPER-3426?jql=project%20%3D%20ZOOKEEPER%20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY%20priority%20DESC%2C%20key%20ASC
> >
> > We have a single remaining blocker, concerning the C client, and it is
> > not currently marked for 3.7.0:
> >
> >   * ZOOKEEPER-3426: ZK prime_connection(the Handshake) can complete
> >     without reading all the payload.
> >
> > (It looks nasty, though, so I will try to have a look ASAP.)
> >
> > I also hope to get a green light for merging this first iteration of
> > quota support:
> >
> >   * ZOOKEEPER-3301: Enforce the quota limit
> >
> >     https://github.com/apache/zookeeper/pull/934#issuecomment-754882022
> >
> >
> > What do you think?
> >
> > Cheers,
> > Damien Diederen
> >
> > P.-S. — This is my first time as a ZooKeeper release manager, so don't
> > hesitate to point out any perceived or actual missteps!
> >
> >
> >
> > Damien Diederen <dd...@sinenomine.net> writes:
> >> Hi Enrico, all,
> >>
> >> A Happy New Year!
> >>
> >> Yes, I am still willing to take care of 3.7.0.  I thought I would start
> >> once 3.5.9 was out, but I suppose there is no reason not to make
> >> progress in parallel.
> >>
> >> I still have to dig into the tracker and sort the list of applicable
> >> tickets, but was already wondering about the ones below, for which pull
> >> requests are more or less ready.
> >>
> >> (I really would like to include the first one, which is just stalled;
> >> the latter two, which are mine, are perhaps a bit "fresh.")
> >>
> >>   * ZOOKEEPER-3301:Enforce the quota limit
> >>     https://github.com/apache/zookeeper/pull/934
> >>
> >>   * ZOOKEEPER-4026: Complete support for Stat objects (and create2) in
> >>     multi requests
> >>     https://github.com/apache/zookeeper/pull/1559
> >>
> >>   * ZOOKEEPER-4030: Optionally canonicalize host names in quorum SASL
> >>     authentication
> >>     https://github.com/apache/zookeeper/pull/1564
> >>
> >> What do you think?
> >>
> >> I'll ping people on the individual PRs.
> >>
> >> Cheers, -D
> >>
> >>
> >>
> >> Enrico Olivelli <eo...@gmail.com> writes:
> >>> Hi ZooKeepers,
> >>> I feel it is time to deliver 3.7.0 to the public.
> >>>
> >>> Any volunteer ?
> >>> Probably Demien, you already told you were available for this release
> >>>
> >>> Please also remember that there is a VOTE open for 3.5.9
> >>>
> >>> Best regards and Happy new year
> >>> Enrico
>

Re: 3.7.0: Last call for tickets

Posted by Damien Diederen <dd...@sinenomine.net>.
Hi Enrico, all,

Following the instructions in "Create a branch (when you create X.Y.0
and move master to X.Y+1.0)" in Confluence,¹ I noticed that:

 1. The 'mvn release:branch' command does not seem to fully interpolate
    commit messages; I get:

        [maven-release-plugin] prepare branch @{releaseLabel}

    I tried cargo-culting a "-DreleaseLabel=$BRANCH_NAME" in my command,
    but that did not work.  Any tips before I dig deeper?

 2. Tags are named via "release-$RELEASE_VERSION-$RC_NUM", instead of
    "...-rc$RC_NUM" for 3.5+.  Is that on purpose?

Cheers, -D

¹ https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToRelease+using+maven+release+plugin



Damien Diederen <dd...@sinenomine.net> writes:
> Greetings, all,
>
>
> Unless someone objects, this is a last call for tickets before I create
> branches 'branch-3.7' and 'branch-3.7.0' in preparation for a new
> release, aiming for a first candidate in the coming days.
>
> Besides the tickets mentioned below, are there other patches you would
> like to see included in 3.7.0?  If not, I will soon start pushing the
> open tickets to 3.8.0 in Jira.
>
> (Of course, my ticket-tagging, Git-branching, or even publishing a first
> release candidate does not preclude "cherry-picking" further patches.)
>
>
> I already went through (and somewhat cleaned up) these two views:
>
>   * https://issues.apache.org/jira/projects/ZOOKEEPER/versions/12346617
>
>   * https://issues.apache.org/jira/browse/ZOOKEEPER-3426?jql=project%20%3D%20ZOOKEEPER%20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY%20priority%20DESC%2C%20key%20ASC
>
> We have a single remaining blocker, concerning the C client, and it is
> not currently marked for 3.7.0:
>
>   * ZOOKEEPER-3426: ZK prime_connection(the Handshake) can complete
>     without reading all the payload.
>
> (It looks nasty, though, so I will try to have a look ASAP.)
>
> I also hope to get a green light for merging this first iteration of
> quota support:
>
>   * ZOOKEEPER-3301: Enforce the quota limit
>
>     https://github.com/apache/zookeeper/pull/934#issuecomment-754882022
>
>
> What do you think?
>
> Cheers,
> Damien Diederen
>
> P.-S. — This is my first time as a ZooKeeper release manager, so don't
> hesitate to point out any perceived or actual missteps!
>
>
>
> Damien Diederen <dd...@sinenomine.net> writes:
>> Hi Enrico, all,
>>
>> A Happy New Year!
>>
>> Yes, I am still willing to take care of 3.7.0.  I thought I would start
>> once 3.5.9 was out, but I suppose there is no reason not to make
>> progress in parallel.
>>
>> I still have to dig into the tracker and sort the list of applicable
>> tickets, but was already wondering about the ones below, for which pull
>> requests are more or less ready.
>>
>> (I really would like to include the first one, which is just stalled;
>> the latter two, which are mine, are perhaps a bit "fresh.")
>>
>>   * ZOOKEEPER-3301:Enforce the quota limit
>>     https://github.com/apache/zookeeper/pull/934
>>
>>   * ZOOKEEPER-4026: Complete support for Stat objects (and create2) in
>>     multi requests
>>     https://github.com/apache/zookeeper/pull/1559
>>
>>   * ZOOKEEPER-4030: Optionally canonicalize host names in quorum SASL
>>     authentication
>>     https://github.com/apache/zookeeper/pull/1564
>>
>> What do you think?
>>
>> I'll ping people on the individual PRs.
>>
>> Cheers, -D
>>
>>
>>
>> Enrico Olivelli <eo...@gmail.com> writes:
>>> Hi ZooKeepers,
>>> I feel it is time to deliver 3.7.0 to the public.
>>>
>>> Any volunteer ?
>>> Probably Demien, you already told you were available for this release
>>>
>>> Please also remember that there is a VOTE open for 3.5.9
>>>
>>> Best regards and Happy new year
>>> Enrico

Re: 3.7.0: Last call for tickets

Posted by Damien Diederen <dd...@apache.org>.
Hi Máté,

Szalay-Bekő Máté <sz...@gmail.com> writes:
> Thank you Damien!! :)

You're welcome :)

> One thing came to my mind: there was the larger story of the junit upgrade.
> I'm not sure how we are with that. Is it finished? (@Tamas can you
> summarize the status?)
> I see the parent story is still in progress:
> https://issues.apache.org/jira/browse/ZOOKEEPER-3732 (although the most of
> the work is done already)

Okay, noted.

Two subtasks are still open, the first with a PR awaiting review (I'll
have a look):

  * ZOOKEEPER-3851: Upgrade jUnit in ZooKeeper-Contrib
    https://issues.apache.org/jira/browse/ZOOKEEPER-3851
    https://github.com/apache/zookeeper/pull/1388

  * ZOOKEEPER-3853: Upgrade jUnit in ZooKeeper-IT
    https://issues.apache.org/jira/browse/ZOOKEEPER-3853

Cheers, -D



> On Wed, Jan 6, 2021 at 3:06 PM Andor Molnar <an...@apache.org> wrote:
>
>> Hi Damien,
>>
>> Thanks for volunteering as release manager. This is gonna be good fun.
>>
>> I’m not following the tickets closely, but I remember the discussion about
>> deco’ing Java 8 in branch-3.7 and unfortunately we didn’t reached an
>> agreement.
>>
>> Andor
>>
>>
>>
>>
>> > On 2021. Jan 6., at 13:19, Damien Diederen <dd...@sinenomine.net>
>> wrote:
>> >
>> >
>> > Greetings, all,
>> >
>> >
>> > Unless someone objects, this is a last call for tickets before I create
>> > branches 'branch-3.7' and 'branch-3.7.0' in preparation for a new
>> > release, aiming for a first candidate in the coming days.
>> >
>> > Besides the tickets mentioned below, are there other patches you would
>> > like to see included in 3.7.0?  If not, I will soon start pushing the
>> > open tickets to 3.8.0 in Jira.
>> >
>> > (Of course, my ticket-tagging, Git-branching, or even publishing a first
>> > release candidate does not preclude "cherry-picking" further patches.)
>> >
>> >
>> > I already went through (and somewhat cleaned up) these two views:
>> >
>> >  * https://issues.apache.org/jira/projects/ZOOKEEPER/versions/12346617
>> >
>> >  *
>> https://issues.apache.org/jira/browse/ZOOKEEPER-3426?jql=project%20%3D%20ZOOKEEPER%20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY%20priority%20DESC%2C%20key%20ASC
>> >
>> > We have a single remaining blocker, concerning the C client, and it is
>> > not currently marked for 3.7.0:
>> >
>> >  * ZOOKEEPER-3426: ZK prime_connection(the Handshake) can complete
>> >    without reading all the payload.
>> >
>> > (It looks nasty, though, so I will try to have a look ASAP.)
>> >
>> > I also hope to get a green light for merging this first iteration of
>> > quota support:
>> >
>> >  * ZOOKEEPER-3301: Enforce the quota limit
>> >
>> >    https://github.com/apache/zookeeper/pull/934#issuecomment-754882022
>> >
>> >
>> > What do you think?
>> >
>> > Cheers,
>> > Damien Diederen
>> >
>> > P.-S. — This is my first time as a ZooKeeper release manager, so don't
>> > hesitate to point out any perceived or actual missteps!
>> >
>> >
>> >
>> > Damien Diederen <dd...@sinenomine.net> writes:
>> >> Hi Enrico, all,
>> >>
>> >> A Happy New Year!
>> >>
>> >> Yes, I am still willing to take care of 3.7.0.  I thought I would start
>> >> once 3.5.9 was out, but I suppose there is no reason not to make
>> >> progress in parallel.
>> >>
>> >> I still have to dig into the tracker and sort the list of applicable
>> >> tickets, but was already wondering about the ones below, for which pull
>> >> requests are more or less ready.
>> >>
>> >> (I really would like to include the first one, which is just stalled;
>> >> the latter two, which are mine, are perhaps a bit "fresh.")
>> >>
>> >>  * ZOOKEEPER-3301:Enforce the quota limit
>> >>    https://github.com/apache/zookeeper/pull/934
>> >>
>> >>  * ZOOKEEPER-4026: Complete support for Stat objects (and create2) in
>> >>    multi requests
>> >>    https://github.com/apache/zookeeper/pull/1559
>> >>
>> >>  * ZOOKEEPER-4030: Optionally canonicalize host names in quorum SASL
>> >>    authentication
>> >>    https://github.com/apache/zookeeper/pull/1564
>> >>
>> >> What do you think?
>> >>
>> >> I'll ping people on the individual PRs.
>> >>
>> >> Cheers, -D
>> >>
>> >>
>> >>
>> >> Enrico Olivelli <eo...@gmail.com> writes:
>> >>> Hi ZooKeepers,
>> >>> I feel it is time to deliver 3.7.0 to the public.
>> >>>
>> >>> Any volunteer ?
>> >>> Probably Demien, you already told you were available for this release
>> >>>
>> >>> Please also remember that there is a VOTE open for 3.5.9
>> >>>
>> >>> Best regards and Happy new year
>> >>> Enrico
>>
>>

Re: 3.7.0: Last call for tickets

Posted by Damien Diederen <dd...@apache.org>.
Hi Tamas, all,

You wrote:

> The jUnit tests in zk-contrib and zk-it are never called and they are
> not working.  Based on this I would not call them blockers for 3.7.0.

Okay, noted.  I agree.  Thank you for migrating all the other modules!

You have probably seen my review on your WIP zk-contrib PR; I was also
wondering about the number of users of that REST bridge...

  https://github.com/apache/zookeeper/pull/1388#pullrequestreview-562930766

Cheers, -D



Tamas Penzes <ta...@cloudera.com.INVALID> writes:
> Hi All,
>
> Sorry for being slow in answering. The jUnit tests in zk-contrib and zk-it
> are never called and they are not working.
> Based on this I would not call them blockers for 3.7.0.
>
> I tried to fix and convert them to jUnit5, but didn't have time to
> finish them.
> Sadly I'm also very busy nowadays and don't have time to work on them now
> either. If someone feels the power to help me out I'd really appreciate it.
>
> Regards, Tamaas
>
> On Wed, Jan 6, 2021 at 4:03 PM Szalay-Bekő Máté <sz...@gmail.com>
> wrote:
>
>> Thank you Damien!! :)
>>
>> One thing came to my mind: there was the larger story of the junit upgrade.
>> I'm not sure how we are with that. Is it finished? (@Tamas can you
>> summarize the status?)
>> I see the parent story is still in progress:
>> https://issues.apache.org/jira/browse/ZOOKEEPER-3732 (although the most of
>> the work is done already)
>>
>> Kind regards,
>> Mate
>>
>> On Wed, Jan 6, 2021 at 3:06 PM Andor Molnar <an...@apache.org> wrote:
>>
>> > Hi Damien,
>> >
>> > Thanks for volunteering as release manager. This is gonna be good fun.
>> >
>> > I’m not following the tickets closely, but I remember the discussion
>> about
>> > deco’ing Java 8 in branch-3.7 and unfortunately we didn’t reached an
>> > agreement.
>> >
>> > Andor
>> >
>> >
>> >
>> >
>> > > On 2021. Jan 6., at 13:19, Damien Diederen <dd...@sinenomine.net>
>> > wrote:
>> > >
>> > >
>> > > Greetings, all,
>> > >
>> > >
>> > > Unless someone objects, this is a last call for tickets before I create
>> > > branches 'branch-3.7' and 'branch-3.7.0' in preparation for a new
>> > > release, aiming for a first candidate in the coming days.
>> > >
>> > > Besides the tickets mentioned below, are there other patches you would
>> > > like to see included in 3.7.0?  If not, I will soon start pushing the
>> > > open tickets to 3.8.0 in Jira.
>> > >
>> > > (Of course, my ticket-tagging, Git-branching, or even publishing a
>> first
>> > > release candidate does not preclude "cherry-picking" further patches.)
>> > >
>> > >
>> > > I already went through (and somewhat cleaned up) these two views:
>> > >
>> > >  * https://issues.apache.org/jira/projects/ZOOKEEPER/versions/12346617
>> > >
>> > >  *
>> >
>> https://issues.apache.org/jira/browse/ZOOKEEPER-3426?jql=project%20%3D%20ZOOKEEPER%20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY%20priority%20DESC%2C%20key%20ASC
>> > >
>> > > We have a single remaining blocker, concerning the C client, and it is
>> > > not currently marked for 3.7.0:
>> > >
>> > >  * ZOOKEEPER-3426: ZK prime_connection(the Handshake) can complete
>> > >    without reading all the payload.
>> > >
>> > > (It looks nasty, though, so I will try to have a look ASAP.)
>> > >
>> > > I also hope to get a green light for merging this first iteration of
>> > > quota support:
>> > >
>> > >  * ZOOKEEPER-3301: Enforce the quota limit
>> > >
>> > >    https://github.com/apache/zookeeper/pull/934#issuecomment-754882022
>> > >
>> > >
>> > > What do you think?
>> > >
>> > > Cheers,
>> > > Damien Diederen
>> > >
>> > > P.-S. — This is my first time as a ZooKeeper release manager, so don't
>> > > hesitate to point out any perceived or actual missteps!
>> > >
>> > >
>> > >
>> > > Damien Diederen <dd...@sinenomine.net> writes:
>> > >> Hi Enrico, all,
>> > >>
>> > >> A Happy New Year!
>> > >>
>> > >> Yes, I am still willing to take care of 3.7.0.  I thought I would
>> start
>> > >> once 3.5.9 was out, but I suppose there is no reason not to make
>> > >> progress in parallel.
>> > >>
>> > >> I still have to dig into the tracker and sort the list of applicable
>> > >> tickets, but was already wondering about the ones below, for which
>> pull
>> > >> requests are more or less ready.
>> > >>
>> > >> (I really would like to include the first one, which is just stalled;
>> > >> the latter two, which are mine, are perhaps a bit "fresh.")
>> > >>
>> > >>  * ZOOKEEPER-3301:Enforce the quota limit
>> > >>    https://github.com/apache/zookeeper/pull/934
>> > >>
>> > >>  * ZOOKEEPER-4026: Complete support for Stat objects (and create2) in
>> > >>    multi requests
>> > >>    https://github.com/apache/zookeeper/pull/1559
>> > >>
>> > >>  * ZOOKEEPER-4030: Optionally canonicalize host names in quorum SASL
>> > >>    authentication
>> > >>    https://github.com/apache/zookeeper/pull/1564
>> > >>
>> > >> What do you think?
>> > >>
>> > >> I'll ping people on the individual PRs.
>> > >>
>> > >> Cheers, -D
>> > >>
>> > >>
>> > >>
>> > >> Enrico Olivelli <eo...@gmail.com> writes:
>> > >>> Hi ZooKeepers,
>> > >>> I feel it is time to deliver 3.7.0 to the public.
>> > >>>
>> > >>> Any volunteer ?
>> > >>> Probably Demien, you already told you were available for this release
>> > >>>
>> > >>> Please also remember that there is a VOTE open for 3.5.9
>> > >>>
>> > >>> Best regards and Happy new year
>> > >>> Enrico
>> >
>> >
>>

Re: 3.7.0: Last call for tickets (was: Time to Cut 3.7.0 ?)

Posted by Tamas Penzes <ta...@cloudera.com.INVALID>.
Hi All,

Sorry for being slow in answering. The jUnit tests in zk-contrib and zk-it
are never called and they are not working.
Based on this I would not call them blockers for 3.7.0.

I tried to fix and convert them to jUnit5, but didn't have time to
finish them.
Sadly I'm also very busy nowadays and don't have time to work on them now
either. If someone feels the power to help me out I'd really appreciate it.

Regards, Tamaas

On Wed, Jan 6, 2021 at 4:03 PM Szalay-Bekő Máté <sz...@gmail.com>
wrote:

> Thank you Damien!! :)
>
> One thing came to my mind: there was the larger story of the junit upgrade.
> I'm not sure how we are with that. Is it finished? (@Tamas can you
> summarize the status?)
> I see the parent story is still in progress:
> https://issues.apache.org/jira/browse/ZOOKEEPER-3732 (although the most of
> the work is done already)
>
> Kind regards,
> Mate
>
> On Wed, Jan 6, 2021 at 3:06 PM Andor Molnar <an...@apache.org> wrote:
>
> > Hi Damien,
> >
> > Thanks for volunteering as release manager. This is gonna be good fun.
> >
> > I’m not following the tickets closely, but I remember the discussion
> about
> > deco’ing Java 8 in branch-3.7 and unfortunately we didn’t reached an
> > agreement.
> >
> > Andor
> >
> >
> >
> >
> > > On 2021. Jan 6., at 13:19, Damien Diederen <dd...@sinenomine.net>
> > wrote:
> > >
> > >
> > > Greetings, all,
> > >
> > >
> > > Unless someone objects, this is a last call for tickets before I create
> > > branches 'branch-3.7' and 'branch-3.7.0' in preparation for a new
> > > release, aiming for a first candidate in the coming days.
> > >
> > > Besides the tickets mentioned below, are there other patches you would
> > > like to see included in 3.7.0?  If not, I will soon start pushing the
> > > open tickets to 3.8.0 in Jira.
> > >
> > > (Of course, my ticket-tagging, Git-branching, or even publishing a
> first
> > > release candidate does not preclude "cherry-picking" further patches.)
> > >
> > >
> > > I already went through (and somewhat cleaned up) these two views:
> > >
> > >  * https://issues.apache.org/jira/projects/ZOOKEEPER/versions/12346617
> > >
> > >  *
> >
> https://issues.apache.org/jira/browse/ZOOKEEPER-3426?jql=project%20%3D%20ZOOKEEPER%20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY%20priority%20DESC%2C%20key%20ASC
> > >
> > > We have a single remaining blocker, concerning the C client, and it is
> > > not currently marked for 3.7.0:
> > >
> > >  * ZOOKEEPER-3426: ZK prime_connection(the Handshake) can complete
> > >    without reading all the payload.
> > >
> > > (It looks nasty, though, so I will try to have a look ASAP.)
> > >
> > > I also hope to get a green light for merging this first iteration of
> > > quota support:
> > >
> > >  * ZOOKEEPER-3301: Enforce the quota limit
> > >
> > >    https://github.com/apache/zookeeper/pull/934#issuecomment-754882022
> > >
> > >
> > > What do you think?
> > >
> > > Cheers,
> > > Damien Diederen
> > >
> > > P.-S. — This is my first time as a ZooKeeper release manager, so don't
> > > hesitate to point out any perceived or actual missteps!
> > >
> > >
> > >
> > > Damien Diederen <dd...@sinenomine.net> writes:
> > >> Hi Enrico, all,
> > >>
> > >> A Happy New Year!
> > >>
> > >> Yes, I am still willing to take care of 3.7.0.  I thought I would
> start
> > >> once 3.5.9 was out, but I suppose there is no reason not to make
> > >> progress in parallel.
> > >>
> > >> I still have to dig into the tracker and sort the list of applicable
> > >> tickets, but was already wondering about the ones below, for which
> pull
> > >> requests are more or less ready.
> > >>
> > >> (I really would like to include the first one, which is just stalled;
> > >> the latter two, which are mine, are perhaps a bit "fresh.")
> > >>
> > >>  * ZOOKEEPER-3301:Enforce the quota limit
> > >>    https://github.com/apache/zookeeper/pull/934
> > >>
> > >>  * ZOOKEEPER-4026: Complete support for Stat objects (and create2) in
> > >>    multi requests
> > >>    https://github.com/apache/zookeeper/pull/1559
> > >>
> > >>  * ZOOKEEPER-4030: Optionally canonicalize host names in quorum SASL
> > >>    authentication
> > >>    https://github.com/apache/zookeeper/pull/1564
> > >>
> > >> What do you think?
> > >>
> > >> I'll ping people on the individual PRs.
> > >>
> > >> Cheers, -D
> > >>
> > >>
> > >>
> > >> Enrico Olivelli <eo...@gmail.com> writes:
> > >>> Hi ZooKeepers,
> > >>> I feel it is time to deliver 3.7.0 to the public.
> > >>>
> > >>> Any volunteer ?
> > >>> Probably Demien, you already told you were available for this release
> > >>>
> > >>> Please also remember that there is a VOTE open for 3.5.9
> > >>>
> > >>> Best regards and Happy new year
> > >>> Enrico
> >
> >
>

Re: 3.7.0: Last call for tickets (was: Time to Cut 3.7.0 ?)

Posted by Szalay-Bekő Máté <sz...@gmail.com>.
Thank you Damien!! :)

One thing came to my mind: there was the larger story of the junit upgrade.
I'm not sure how we are with that. Is it finished? (@Tamas can you
summarize the status?)
I see the parent story is still in progress:
https://issues.apache.org/jira/browse/ZOOKEEPER-3732 (although the most of
the work is done already)

Kind regards,
Mate

On Wed, Jan 6, 2021 at 3:06 PM Andor Molnar <an...@apache.org> wrote:

> Hi Damien,
>
> Thanks for volunteering as release manager. This is gonna be good fun.
>
> I’m not following the tickets closely, but I remember the discussion about
> deco’ing Java 8 in branch-3.7 and unfortunately we didn’t reached an
> agreement.
>
> Andor
>
>
>
>
> > On 2021. Jan 6., at 13:19, Damien Diederen <dd...@sinenomine.net>
> wrote:
> >
> >
> > Greetings, all,
> >
> >
> > Unless someone objects, this is a last call for tickets before I create
> > branches 'branch-3.7' and 'branch-3.7.0' in preparation for a new
> > release, aiming for a first candidate in the coming days.
> >
> > Besides the tickets mentioned below, are there other patches you would
> > like to see included in 3.7.0?  If not, I will soon start pushing the
> > open tickets to 3.8.0 in Jira.
> >
> > (Of course, my ticket-tagging, Git-branching, or even publishing a first
> > release candidate does not preclude "cherry-picking" further patches.)
> >
> >
> > I already went through (and somewhat cleaned up) these two views:
> >
> >  * https://issues.apache.org/jira/projects/ZOOKEEPER/versions/12346617
> >
> >  *
> https://issues.apache.org/jira/browse/ZOOKEEPER-3426?jql=project%20%3D%20ZOOKEEPER%20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY%20priority%20DESC%2C%20key%20ASC
> >
> > We have a single remaining blocker, concerning the C client, and it is
> > not currently marked for 3.7.0:
> >
> >  * ZOOKEEPER-3426: ZK prime_connection(the Handshake) can complete
> >    without reading all the payload.
> >
> > (It looks nasty, though, so I will try to have a look ASAP.)
> >
> > I also hope to get a green light for merging this first iteration of
> > quota support:
> >
> >  * ZOOKEEPER-3301: Enforce the quota limit
> >
> >    https://github.com/apache/zookeeper/pull/934#issuecomment-754882022
> >
> >
> > What do you think?
> >
> > Cheers,
> > Damien Diederen
> >
> > P.-S. — This is my first time as a ZooKeeper release manager, so don't
> > hesitate to point out any perceived or actual missteps!
> >
> >
> >
> > Damien Diederen <dd...@sinenomine.net> writes:
> >> Hi Enrico, all,
> >>
> >> A Happy New Year!
> >>
> >> Yes, I am still willing to take care of 3.7.0.  I thought I would start
> >> once 3.5.9 was out, but I suppose there is no reason not to make
> >> progress in parallel.
> >>
> >> I still have to dig into the tracker and sort the list of applicable
> >> tickets, but was already wondering about the ones below, for which pull
> >> requests are more or less ready.
> >>
> >> (I really would like to include the first one, which is just stalled;
> >> the latter two, which are mine, are perhaps a bit "fresh.")
> >>
> >>  * ZOOKEEPER-3301:Enforce the quota limit
> >>    https://github.com/apache/zookeeper/pull/934
> >>
> >>  * ZOOKEEPER-4026: Complete support for Stat objects (and create2) in
> >>    multi requests
> >>    https://github.com/apache/zookeeper/pull/1559
> >>
> >>  * ZOOKEEPER-4030: Optionally canonicalize host names in quorum SASL
> >>    authentication
> >>    https://github.com/apache/zookeeper/pull/1564
> >>
> >> What do you think?
> >>
> >> I'll ping people on the individual PRs.
> >>
> >> Cheers, -D
> >>
> >>
> >>
> >> Enrico Olivelli <eo...@gmail.com> writes:
> >>> Hi ZooKeepers,
> >>> I feel it is time to deliver 3.7.0 to the public.
> >>>
> >>> Any volunteer ?
> >>> Probably Demien, you already told you were available for this release
> >>>
> >>> Please also remember that there is a VOTE open for 3.5.9
> >>>
> >>> Best regards and Happy new year
> >>> Enrico
>
>

Re: 3.7.0: Last call for tickets (was: Time to Cut 3.7.0 ?)

Posted by Andor Molnar <an...@apache.org>.
Hi Damien,

Thanks for volunteering as release manager. This is gonna be good fun.

I’m not following the tickets closely, but I remember the discussion about deco’ing Java 8 in branch-3.7 and unfortunately we didn’t reached an agreement.

Andor




> On 2021. Jan 6., at 13:19, Damien Diederen <dd...@sinenomine.net> wrote:
> 
> 
> Greetings, all,
> 
> 
> Unless someone objects, this is a last call for tickets before I create
> branches 'branch-3.7' and 'branch-3.7.0' in preparation for a new
> release, aiming for a first candidate in the coming days.
> 
> Besides the tickets mentioned below, are there other patches you would
> like to see included in 3.7.0?  If not, I will soon start pushing the
> open tickets to 3.8.0 in Jira.
> 
> (Of course, my ticket-tagging, Git-branching, or even publishing a first
> release candidate does not preclude "cherry-picking" further patches.)
> 
> 
> I already went through (and somewhat cleaned up) these two views:
> 
>  * https://issues.apache.org/jira/projects/ZOOKEEPER/versions/12346617
> 
>  * https://issues.apache.org/jira/browse/ZOOKEEPER-3426?jql=project%20%3D%20ZOOKEEPER%20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY%20priority%20DESC%2C%20key%20ASC
> 
> We have a single remaining blocker, concerning the C client, and it is
> not currently marked for 3.7.0:
> 
>  * ZOOKEEPER-3426: ZK prime_connection(the Handshake) can complete
>    without reading all the payload.
> 
> (It looks nasty, though, so I will try to have a look ASAP.)
> 
> I also hope to get a green light for merging this first iteration of
> quota support:
> 
>  * ZOOKEEPER-3301: Enforce the quota limit
> 
>    https://github.com/apache/zookeeper/pull/934#issuecomment-754882022
> 
> 
> What do you think?
> 
> Cheers,
> Damien Diederen
> 
> P.-S. — This is my first time as a ZooKeeper release manager, so don't
> hesitate to point out any perceived or actual missteps!
> 
> 
> 
> Damien Diederen <dd...@sinenomine.net> writes:
>> Hi Enrico, all,
>> 
>> A Happy New Year!
>> 
>> Yes, I am still willing to take care of 3.7.0.  I thought I would start
>> once 3.5.9 was out, but I suppose there is no reason not to make
>> progress in parallel.
>> 
>> I still have to dig into the tracker and sort the list of applicable
>> tickets, but was already wondering about the ones below, for which pull
>> requests are more or less ready.
>> 
>> (I really would like to include the first one, which is just stalled;
>> the latter two, which are mine, are perhaps a bit "fresh.")
>> 
>>  * ZOOKEEPER-3301:Enforce the quota limit
>>    https://github.com/apache/zookeeper/pull/934
>> 
>>  * ZOOKEEPER-4026: Complete support for Stat objects (and create2) in
>>    multi requests
>>    https://github.com/apache/zookeeper/pull/1559
>> 
>>  * ZOOKEEPER-4030: Optionally canonicalize host names in quorum SASL
>>    authentication
>>    https://github.com/apache/zookeeper/pull/1564
>> 
>> What do you think?
>> 
>> I'll ping people on the individual PRs.
>> 
>> Cheers, -D
>> 
>> 
>> 
>> Enrico Olivelli <eo...@gmail.com> writes:
>>> Hi ZooKeepers,
>>> I feel it is time to deliver 3.7.0 to the public.
>>> 
>>> Any volunteer ?
>>> Probably Demien, you already told you were available for this release
>>> 
>>> Please also remember that there is a VOTE open for 3.5.9
>>> 
>>> Best regards and Happy new year
>>> Enrico