You are viewing a plain text version of this content. The canonical link for it is here.

Posted to oak-dev@jackrabbit.apache.org by Angela Schreiber <an...@adobe.com> on 2014/02/06 10:30:08 UTC

Drop TODO.java

hi all

in an attempt to clean up our utility folder, i had a quick look if the
TODO class 
introduced with OAK-193 is still used.

while we originally used it to mark mandatory features and allow us to
start
integration testing without having those features completed, i think we
should
aim for dropping the TODO and mark the missing features with a regular
UnsupportedRepositoryOperationException.

right now the only usages left are in the version related code and afaik
the only crucial but missing features marked with the TODO are:

1) VersionHistory#removeVersion
2) Proper support for OPV INITIALIZE  (VersionableState ll 106)

so, my suggestion would be to fix these two open issues before releasing
1.0
and replace all other TODO usages by
UnsupportedRepositoryOperationException,
namely

- VersionManager#merge
- VersionManager#cancelMerge

- VersionManager#doneMerge


- VersionManager#createActivity
- VersionManager#removeActivity

- VersionManager#setActivity


- VersionManager#createConfiguration


- VersionManager#restore(Version[])

- VersionManager#restoryByLabel


any concern or objection?

kind regards
angela

Re: Drop TODO.java

Posted by Angela Schreiber <an...@adobe.com>.

covered by https://issues.apache.org/jira/browse/OAK-1399

regards
angela

On 06/02/14 10:30, "Angela Schreiber" <an...@adobe.com> wrote:

>hi all
>
>in an attempt to clean up our utility folder, i had a quick look if the
>TODO class 
>introduced with OAK-193 is still used.
>
>while we originally used it to mark mandatory features and allow us to
>start
>integration testing without having those features completed, i think we
>should
>aim for dropping the TODO and mark the missing features with a regular
>UnsupportedRepositoryOperationException.
>
>right now the only usages left are in the version related code and afaik
>the only crucial but missing features marked with the TODO are:
>
>1) VersionHistory#removeVersion
>2) Proper support for OPV INITIALIZE  (VersionableState ll 106)
>
>so, my suggestion would be to fix these two open issues before releasing
>1.0
>and replace all other TODO usages by
>UnsupportedRepositoryOperationException,
>namely
>
>- VersionManager#merge
>- VersionManager#cancelMerge
>
>- VersionManager#doneMerge
>
>
>- VersionManager#createActivity
>- VersionManager#removeActivity
>
>- VersionManager#setActivity
>
>
>- VersionManager#createConfiguration
>
>
>- VersionManager#restore(Version[])
>
>- VersionManager#restoryByLabel
>
>
>any concern or objection?
>
>kind regards
>angela
>
>
>
>
>

Re: Drop TODO.java

Posted by Jukka Zitting <ju...@gmail.com>.

Hi,

On Thu, Feb 6, 2014 at 4:30 AM, Angela Schreiber <an...@adobe.com> wrote:
> any concern or objection?

None. As you said, the class has pretty much served its purpose
already, so removing it is just one more TODO to be done.

BR,

Jukka Zitting